Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1219123002: Convert chromeos_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 5 months ago
Reviewers:
stevenjb, M-A Ruel
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert chromeos_unittests to run exclusively on Swarming 0 configs already ran on Swarming 6 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) Ran: ./manage.py --convert chromeos_unittests BUG=98637 Committed: https://crrev.com/b740ceb41acd9e8279638743a9e7d09a0e7ae7d3 Cr-Commit-Position: refs/heads/master@{#336926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M chromeos/chromeos.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A chromeos/chromeos_unittests.isolate View 1 chunk +25 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 5 months ago (2015-06-30 23:31:47 UTC) #2
M-A Ruel
lgtm (I normally also update build/gn_migration.gypi but it's not a big deal, it can be ...
5 years, 5 months ago (2015-06-30 23:40:18 UTC) #3
stevenjb
owner rubberstamp lgtm
5 years, 5 months ago (2015-06-30 23:49:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219123002/1
5 years, 5 months ago (2015-06-30 23:50:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 00:00:15 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 00:01:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b740ceb41acd9e8279638743a9e7d09a0e7ae7d3
Cr-Commit-Position: refs/heads/master@{#336926}

Powered by Google App Engine
This is Rietveld 408576698