sky/sdk/lib/rendering/paragraph.dart - Issue 1219113003: Make popup menus line up to their baseline per the Material spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/rendering/paragraph.dart

Issue 1219113003: Make popup menus line up to their baseline per the Material spec. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/rendering/paragraph.dart

diff --git a/sky/sdk/lib/rendering/paragraph.dart b/sky/sdk/lib/rendering/paragraph.dart

index dcce468cb7b783e98bd4f8d105f4855f3581bd77..75cdcdba32d62bb5517bbcdafaa79b3e7600da31 100644

--- a/sky/sdk/lib/rendering/paragraph.dart

+++ b/sky/sdk/lib/rendering/paragraph.dart

@@ -154,7 +154,7 @@ class RenderParagraph extends RenderBox {

return _getIntrinsicHeight(constraints);

}

- double getDistanceToActualBaseline(TextBaseline baseline) {

+ double computeDistanceToActualBaseline(TextBaseline baseline, RenderObject client) {

assert(!needsLayout);

_layout(constraints);

sky.Element root = _layoutRoot.rootElement;