Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: sky/sdk/lib/rendering/flex.dart

Issue 1219113003: Make popup menus line up to their baseline per the Material spec. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/rendering/flex.dart
diff --git a/sky/sdk/lib/rendering/flex.dart b/sky/sdk/lib/rendering/flex.dart
index e4b7422a3c055b52ad160e231c7504a62af40372..5919ab1d72fdfc04dba1fa4490ce39db8e85b55c 100644
--- a/sky/sdk/lib/rendering/flex.dart
+++ b/sky/sdk/lib/rendering/flex.dart
@@ -246,11 +246,10 @@ class RenderFlex extends RenderBox with ContainerRenderObjectMixin<RenderBox, Fl
childSize: (c, innerConstraints) => c.getMaxIntrinsicHeight(innerConstraints));
}
- double getDistanceToActualBaseline(TextBaseline baseline) {
- assert(!needsLayout);
+ double computeDistanceToActualBaseline(TextBaseline baseline, RenderObject client) {
if (_direction == FlexDirection.horizontal)
- return defaultGetDistanceToHighestActualBaseline(baseline);
- return defaultGetDistanceToFirstActualBaseline(baseline);
+ return defaultComputeDistanceToHighestActualBaseline(baseline, client);
+ return defaultComputeDistanceToFirstActualBaseline(baseline, client);
}
int _getFlex(RenderBox child) {

Powered by Google App Engine
This is Rietveld 408576698