sky/sdk/lib/rendering/block.dart - Issue 1219113003: Make popup menus line up to their baseline per the Material spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/rendering/block.dart

Issue 1219113003: Make popup menus line up to their baseline per the Material spec. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/rendering/block.dart

diff --git a/sky/sdk/lib/rendering/block.dart b/sky/sdk/lib/rendering/block.dart

index a143acda0c9156763812935a26ad1bef97e0a1fb..07eec96cbc3c5887975a7c7c4723ff19a0826c36 100644

--- a/sky/sdk/lib/rendering/block.dart

+++ b/sky/sdk/lib/rendering/block.dart

@@ -77,8 +77,8 @@ class RenderBlock extends RenderBox with ContainerRenderObjectMixin<RenderBox, B

return _getIntrinsicHeight(constraints);

}

- double getDistanceToActualBaseline(TextBaseline baseline) {

- return defaultGetDistanceToFirstActualBaseline(baseline);

+ double computeDistanceToActualBaseline(TextBaseline baseline, RenderObject client) {

+ return defaultComputeDistanceToFirstActualBaseline(baseline, client);

}

void performLayout() {