Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: sky/sdk/lib/rendering/block.dart

Issue 1219113003: Make popup menus line up to their baseline per the Material spec. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:math' as math; 5 import 'dart:math' as math;
6 6
7 import 'box.dart'; 7 import 'box.dart';
8 import 'object.dart'; 8 import 'object.dart';
9 9
10 class BlockParentData extends BoxParentData with ContainerParentDataMixin<Render Box> { } 10 class BlockParentData extends BoxParentData with ContainerParentDataMixin<Render Box> { }
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 } 70 }
71 71
72 double getMinIntrinsicHeight(BoxConstraints constraints) { 72 double getMinIntrinsicHeight(BoxConstraints constraints) {
73 return _getIntrinsicHeight(constraints); 73 return _getIntrinsicHeight(constraints);
74 } 74 }
75 75
76 double getMaxIntrinsicHeight(BoxConstraints constraints) { 76 double getMaxIntrinsicHeight(BoxConstraints constraints) {
77 return _getIntrinsicHeight(constraints); 77 return _getIntrinsicHeight(constraints);
78 } 78 }
79 79
80 double getDistanceToActualBaseline(TextBaseline baseline) { 80 double computeDistanceToActualBaseline(TextBaseline baseline) {
81 return defaultGetDistanceToFirstActualBaseline(baseline); 81 return defaultComputeDistanceToFirstActualBaseline(baseline);
82 } 82 }
83 83
84 void performLayout() { 84 void performLayout() {
85 assert(constraints is BoxConstraints); 85 assert(constraints is BoxConstraints);
86 double width = constraints.constrainWidth(constraints.maxWidth); 86 double width = constraints.constrainWidth(constraints.maxWidth);
87 BoxConstraints innerConstraints = _getInnerConstraintsForWidth(width); 87 BoxConstraints innerConstraints = _getInnerConstraintsForWidth(width);
88 double y = 0.0; 88 double y = 0.0;
89 RenderBox child = firstChild; 89 RenderBox child = firstChild;
90 while (child != null) { 90 while (child != null) {
91 child.layout(innerConstraints, parentUsesSize: true); 91 child.layout(innerConstraints, parentUsesSize: true);
92 assert(child.parentData is BlockParentData); 92 assert(child.parentData is BlockParentData);
93 child.parentData.position = new Point(0.0, y); 93 child.parentData.position = new Point(0.0, y);
94 y += child.size.height; 94 y += child.size.height;
95 child = child.parentData.nextSibling; 95 child = child.parentData.nextSibling;
96 } 96 }
97 size = new Size(width, constraints.constrainHeight(y)); 97 size = new Size(width, constraints.constrainHeight(y));
98 assert(!size.isInfinite); 98 assert(!size.isInfinite);
99 } 99 }
100 100
101 void hitTestChildren(HitTestResult result, { Point position }) { 101 void hitTestChildren(HitTestResult result, { Point position }) {
102 defaultHitTestChildren(result, position: position); 102 defaultHitTestChildren(result, position: position);
103 } 103 }
104 104
105 void paint(PaintingCanvas canvas, Offset offset) { 105 void paint(PaintingCanvas canvas, Offset offset) {
106 defaultPaint(canvas, offset); 106 defaultPaint(canvas, offset);
107 } 107 }
108 108
109 } 109 }
110 110
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698