runtime/observatory/lib/src/service/object.dart - Issue 1219103002: Deal with Javascript integer limitations in heap snapshot processing to handle 64-bit target VMs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1219103002: Deal with Javascript integer limitations in heap snapshot processing to handle 64-bit target VMs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/elements/heap_snapshot.dart ('k') | runtime/observatory/tests/service/address_mapper_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/service/object.dart

diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart

index 0eee58f8a2ca4b30ab15fa6483da929c5693d639..e6825786f50c19d78f6a89c78e46cec34b9a391f 100644

--- a/runtime/observatory/lib/src/service/object.dart

+++ b/runtime/observatory/lib/src/service/object.dart

@@ -936,7 +936,7 @@ class HeapSnapshot {

var result = [];

for (ObjectVertex v in graph.getMostRetained(classId: classId,

limit: limit)) {

- result.add(isolate.getObjectByAddress(v.address.toRadixString(16))

+ result.add(isolate.getObjectByAddress(v.address)

.then((ServiceObject obj) {

if (obj is Instance) {

// TODO(rmacnak): size/retainedSize are properties of all heap