Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: runtime/observatory/lib/src/elements/heap_snapshot.dart

Issue 1219103002: Deal with Javascript integer limitations in heap snapshot processing to handle 64-bit target VMs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library heap_snapshot_element; 5 library heap_snapshot_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'observatory_element.dart'; 9 import 'observatory_element.dart';
10 import 'package:observatory/app.dart'; 10 import 'package:observatory/app.dart';
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 percentNode.title = "Percent of heap being retained"; 68 percentNode.title = "Percent of heap being retained";
69 percentNode.style.display = 'inline-block'; 69 percentNode.style.display = 'inline-block';
70 firstColumn.children.add(percentNode); 70 firstColumn.children.add(percentNode);
71 71
72 var gap = new SpanElement(); 72 var gap = new SpanElement();
73 gap.style.minWidth = '1em'; 73 gap.style.minWidth = '1em';
74 gap.style.display = 'inline-block'; 74 gap.style.display = 'inline-block';
75 firstColumn.children.add(gap); 75 firstColumn.children.add(gap);
76 76
77 AnyServiceRefElement objectRef = new Element.tag("any-service-ref"); 77 AnyServiceRefElement objectRef = new Element.tag("any-service-ref");
78 String hexAddress = vertex.address.toRadixString(16); 78 snapshot.isolate.getObjectByAddress(vertex.address).then((obj) {
79 snapshot.isolate.getObjectByAddress(hexAddress).then((obj) {
80 objectRef.ref = obj; 79 objectRef.ref = obj;
81 }); 80 });
82 objectRef.style.alignSelf = 'center'; 81 objectRef.style.alignSelf = 'center';
83 firstColumn.children.add(objectRef); 82 firstColumn.children.add(objectRef);
84 83
85 var secondColumn = flexColumns[1]; 84 var secondColumn = flexColumns[1];
86 secondColumn.style.justifyContent = 'flex-end'; 85 secondColumn.style.justifyContent = 'flex-end';
87 secondColumn.style.position = 'relative'; 86 secondColumn.style.position = 'relative';
88 secondColumn.style.alignItems = 'center'; 87 secondColumn.style.alignItems = 'center';
89 secondColumn.style.paddingRight = '0.5em'; 88 secondColumn.style.paddingRight = '0.5em';
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 451
453 new Future.delayed(const Duration(milliseconds: 500), () { 452 new Future.delayed(const Duration(milliseconds: 500), () {
454 buildMergedVertices(snapshot.graph).then((vertices) { 453 buildMergedVertices(snapshot.graph).then((vertices) {
455 state = 'Loaded'; 454 state = 'Loaded';
456 var rootRow = new MergedVerticesRow(tree, null, isolate, vertices); 455 var rootRow = new MergedVerticesRow(tree, null, isolate, vertices);
457 tree.initialize(rootRow); 456 tree.initialize(rootRow);
458 }); 457 });
459 }); 458 });
460 } 459 }
461 } 460 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/object_graph.dart ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698