content/browser/web_contents/web_contents_impl.cc - Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased view_messages.h and fixed the link issue on the linux bot Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index a062f18fa47c36b9e53e08b35ae69a888ea4bc64..02dbcb0de1ffb3b50bfc79592d1524b91530610d 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2350,9 +2350,12 @@ void WebContentsImpl::OnFindMatchRectsReply(

delegate_->FindMatchRectsReply(this, version, rects, active_rect);

}

-void WebContentsImpl::OnOpenDateTimeDialog(int type, const std::string& value) {

+void WebContentsImpl::OnOpenDateTimeDialog(

+ const ViewHostMsg_DateTimeDialogValue_Params& value) {

date_time_chooser_->ShowDialog(

- GetContentNativeView(), GetRenderViewHost(), type, value);

+ GetContentNativeView(), GetRenderViewHost(), value.dialog_type,

+ value.year, value.month, value.day, value.hour,

+ value.minute, value.second);

}

#endif

« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/view_messages.h » ('j') | content/renderer/date_time_formatter.h » ('J')