content/renderer/renderer_date_time_picker.h - Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_date_time_picker.h

Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Review comments except renaming the file Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/date_time_formatter.cc ('K') | « content/renderer/date_time_formatter_unittest.cc ('k') | content/renderer/renderer_date_time_picker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_date_time_picker.h

diff --git a/content/renderer/renderer_date_time_picker.h b/content/renderer/renderer_date_time_picker.h

index 1a61227fc823312b0050ac8f352b0bf69b8b02e9..23dcf686193c05e308a20368f2955d6fe480ba5a 100644

--- a/content/renderer/renderer_date_time_picker.h

+++ b/content/renderer/renderer_date_time_picker.h

@@ -8,7 +8,8 @@

#include "base/basictypes.h"

#include "content/public/renderer/render_view_observer.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebDateTimeChooserParams.h"

-#include "ui/base/ime/text_input_type.h"

+struct ViewHostMsg_DateTimeDialogValue_Params;

namespace WebKit {

class WebDateTimeChooserCompletion;

@@ -28,7 +29,7 @@ class RendererDateTimePicker : public RenderViewObserver {

bool Open();

private:

- void OnReplaceDateTime(const string16& new_date);

+ void OnReplaceDateTime(const ViewHostMsg_DateTimeDialogValue_Params& value);

void OnCancel();

// RenderViewObserver

« content/renderer/date_time_formatter.cc ('K') | « content/renderer/date_time_formatter_unittest.cc ('k') | content/renderer/renderer_date_time_picker.cc » ('j') | no next file with comments »