content/browser/web_contents/web_contents_impl.h - Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Review comments except renaming the file Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | content/renderer/date_time_formatter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index b25ff17f9546f91629ae16a7ae4cb60bf67905d2..6e76b2f4e6d6adad37c896330bd4b701ef8c627d 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -31,6 +31,7 @@

struct BrowserPluginHostMsg_CreateGuest_Params;

struct BrowserPluginHostMsg_ResizeGuest_Params;

+struct ViewHostMsg_DateTimeDialogValue_Params;

struct ViewMsg_PostMessage_Params;

namespace webkit_glue {

@@ -557,7 +558,8 @@ class CONTENT_EXPORT WebContentsImpl

const std::vector<gfx::RectF>& rects,

const gfx::RectF& active_rect);

- void OnOpenDateTimeDialog(int type, const std::string& value);

+ void OnOpenDateTimeDialog(

+ const ViewHostMsg_DateTimeDialogValue_Params& value);

#endif

void OnCrashedPlugin(const FilePath& plugin_path, base::ProcessId plugin_pid);

void OnAppCacheAccessed(const GURL& manifest_url, bool blocked_by_policy);