content/common/view_messages.h - Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 12191005: Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.h ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/content_renderer.gypi » ('j') | content/renderer/date_time_formatter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index 22c246d6e8ed9ddb7d1d4a523f8e9e3dfd793527..05ba8ef74d8e9db85b4e744c8f00cad1d053490b 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -358,6 +358,16 @@ IPC_STRUCT_BEGIN(ViewHostMsg_TextInputState_Params)

IPC_STRUCT_MEMBER(bool, show_ime_if_needed)

IPC_STRUCT_END()

+IPC_STRUCT_BEGIN(ViewHostMsg_DateTimeValue_Params)

bulach 2013/02/05 11:54:56 nit: maybe DateTimeDialogValue

Miguel Garcia 2013/02/05 17:44:40 Done.

+ IPC_STRUCT_MEMBER(int, year)

+ IPC_STRUCT_MEMBER(int, month)

+ IPC_STRUCT_MEMBER(int, day)

+ IPC_STRUCT_MEMBER(int, hour)

+ IPC_STRUCT_MEMBER(int, minute)

+ IPC_STRUCT_MEMBER(int, second)

+ IPC_STRUCT_MEMBER(int, dialog_type)

bulach 2013/02/05 11:54:56 nit: maybe start with dialog_type then date? ..if

Miguel Garcia 2013/02/05 17:44:40 Done.

+IPC_STRUCT_END()

IPC_STRUCT_BEGIN(ViewHostMsg_CreateWorker_Params)

// URL for the worker script.

IPC_STRUCT_MEMBER(GURL, url)

@@ -914,7 +924,8 @@ IPC_MESSAGE_ROUTED0(ViewMsg_Delete)

IPC_MESSAGE_ROUTED0(ViewMsg_SelectAll)

// Replaces a date time input field.

-IPC_MESSAGE_ROUTED1(ViewMsg_ReplaceDateTime, string16 /* text */)

+IPC_MESSAGE_ROUTED1(ViewMsg_ReplaceDateTime,

+ ViewHostMsg_DateTimeValue_Params /* value */)

IPC_MESSAGE_ROUTED0(ViewMsg_Unselect)

@@ -1986,9 +1997,8 @@ IPC_MESSAGE_ROUTED1(ViewHostMsg_TakeFocus,

bool /* reverse */)

// Required for opening a date/time dialog

-IPC_MESSAGE_ROUTED2(ViewHostMsg_OpenDateTimeDialog,

- int /* type */,

- std::string /* value */)

+IPC_MESSAGE_ROUTED1(ViewHostMsg_OpenDateTimeDialog,

+ ViewHostMsg_DateTimeValue_Params /* value */)

// Required for updating text input state.

IPC_MESSAGE_ROUTED1(ViewHostMsg_TextInputStateChanged,