Move Android Date/Time parsing to the renderer (C++ and ICU) instead of the current parsing that ha…

content/renderer/date_time_formatter_unittest.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <map>
+
+#include "content/renderer/date_time_formatter.h"
+#include "content/renderer/renderer_date_time_picker.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebDateTimeChooserParams.h"
+#include "third_party/icu/public/common/unicode/unistr.h"
+#include "ui/base/ime/text_input_type.h"
+
+namespace content {
+
+class RendererDateTimePickerTest : public testing::Test {

[bulach, 2013/02/05 11:54:56]

I think it can be just TEST(RendererDateTimePickerTest, ...) and no need for
TEST_F with this harness..

[Miguel Garcia, 2013/02/05 17:44:40]

Indeed

On 2013/02/05 11:54:56, bulach wrote:

+};
+
+TEST_F(RendererDateTimePickerTest, TestParserValidStringInputs) {
+  WebKit::WebDateTimeChooserParams params;
+  params.currentValue = "2010-07";
+  params.type = WebKit::WebDateTimeInputTypeMonth;
+  DateTimeFormatter sut(params);
+  ASSERT_EQ(2010, sut.GetYear());

[bulach, 2013/02/05 11:54:56]

I think EXPECT_EQ is preferred instead of ASSERT_EQ (which throws a fatal
failure)

[Miguel Garcia, 2013/02/05 17:44:40]

Done.

+
+  // Month field is 0 based
+  ASSERT_EQ(6, sut.GetMonth());
+
+  // Month input defaults to the first day of the month (1 based)
+  ASSERT_EQ(1, sut.GetDay());
+  ASSERT_EQ(0, sut.GetHour());
+  ASSERT_EQ(0, sut.GetMinute());
+  ASSERT_EQ(0, sut.GetSecond());
+  ASSERT_EQ(ui::TEXT_INPUT_TYPE_MONTH, sut.GetType());
+
+  params.currentValue = "2012-05-25";
+  params.type = WebKit::WebDateTimeInputTypeDate;
+  DateTimeFormatter sut2(params);
+  ASSERT_EQ(2012, sut2.GetYear());
+  ASSERT_EQ(4, sut2.GetMonth());
+  ASSERT_EQ(25, sut2.GetDay());
+  ASSERT_EQ(0, sut2.GetHour());
+  ASSERT_EQ(0, sut2.GetMinute());
+  ASSERT_EQ(0, sut2.GetSecond());
+  ASSERT_EQ(ui::TEXT_INPUT_TYPE_DATE, sut2.GetType());
+
+  params.currentValue = "2013-05-21T12:15";
+  params.type = WebKit::WebDateTimeInputTypeDateTimeLocal;
+  DateTimeFormatter sut3(params);
+  ASSERT_EQ(2013, sut3.GetYear());
+  ASSERT_EQ(4, sut3.GetMonth());
+  ASSERT_EQ(21, sut3.GetDay());
+  ASSERT_EQ(12, sut3.GetHour());
+  ASSERT_EQ(15, sut3.GetMinute());
+  ASSERT_EQ(0, sut3.GetSecond());
+  ASSERT_EQ(ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL, sut3.GetType());
+}
+
+
+TEST_F(RendererDateTimePickerTest, TestParserInvalidStringInputs) {
+
+  // Random non parsable text
+  WebKit::WebDateTimeChooserParams params;
+  params.currentValue = "<script injection";
+  params.type = WebKit::WebDateTimeInputTypeMonth;
+  DateTimeFormatter sut(params);
+  ASSERT_EQ(0, sut.GetYear());
+  ASSERT_EQ(0, sut.GetMonth());
+  ASSERT_EQ(0, sut.GetDay());
+  ASSERT_EQ(0, sut.GetHour());
+  ASSERT_EQ(0, sut.GetMinute());
+  ASSERT_EQ(0, sut.GetSecond());
+  ASSERT_EQ(ui::TEXT_INPUT_TYPE_NONE, sut.GetType());
+
+  // unimplemented type
+  params.currentValue = "week 23";
+  params.type = WebKit::WebDateTimeInputTypeWeek; // Not implemented
+  DateTimeFormatter sut2(params);
+  ASSERT_EQ(0, sut2.GetYear());
+  ASSERT_EQ(0, sut2.GetMonth());
+  ASSERT_EQ(0, sut2.GetDay());
+  ASSERT_EQ(0, sut2.GetHour());
+  ASSERT_EQ(0, sut2.GetMinute());
+  ASSERT_EQ(0, sut2.GetSecond());
+  ASSERT_EQ(ui::TEXT_INPUT_TYPE_NONE, sut2.GetType());
+
+  // type is a subset of pattern
+  params.currentValue = "2012-05-25";
+  params.type = WebKit::WebDateTimeInputTypeDateTimeLocal;
+  DateTimeFormatter sut3(params);
+  ASSERT_EQ(0, sut3.GetYear());
+  ASSERT_EQ(0, sut3.GetMonth());
+  ASSERT_EQ(0, sut3.GetDay());
+  ASSERT_EQ(0, sut3.GetHour());
+  ASSERT_EQ(0, sut3.GetMinute());
+  ASSERT_EQ(0, sut3.GetSecond());
+  ASSERT_EQ(ui::TEXT_INPUT_TYPE_NONE, sut3.GetType());
+
+  // type is a superset of pattern
+  params.currentValue = "2013-05-21T12:15";
+  params.type = WebKit::WebDateTimeInputTypeMonth;
+  DateTimeFormatter sut4(params);
+  ASSERT_EQ(2013, sut4.GetYear());
+  ASSERT_EQ(4, sut4.GetMonth());
+  ASSERT_EQ(1, sut4.GetDay());
+  ASSERT_EQ(0, sut4.GetHour());
+  ASSERT_EQ(0, sut4.GetMinute());
+  ASSERT_EQ(0, sut4.GetSecond());
+  ASSERT_EQ(ui::TEXT_INPUT_TYPE_MONTH, sut4.GetType());
+}
+
+
+TEST_F(RendererDateTimePickerTest, TestParserValidDateInputs) {
+  DateTimeFormatter sut(ui::TEXT_INPUT_TYPE_MONTH, 2012, 11, 1, 0, 0, 0);
+  ASSERT_EQ("2012-12", sut.GetFormattedValue());
+
+
+  DateTimeFormatter sut2(ui::TEXT_INPUT_TYPE_DATE_TIME_LOCAL,
+                         2013, 3, 23, 15, 47, 0);
+  ASSERT_EQ("2013-04-23T15:47", sut2.GetFormattedValue());
+}
+
+TEST_F(RendererDateTimePickerTest, TestParserInvalidDateInputs) {
+  DateTimeFormatter sut(ui::TEXT_INPUT_TYPE_WEEK, 2012, 2, 0, 0, 0, 0);
+  ASSERT_EQ("", sut.GetFormattedValue());
+
+  DateTimeFormatter sut2(ui::TEXT_INPUT_TYPE_NONE, 2013, 3, 23, 0, 0, 0);
+  ASSERT_EQ("", sut2.GetFormattedValue());
+
+  DateTimeFormatter sut3(ui::TEXT_INPUT_TYPE_NONE, 2013, 14, 32, 0, 0, 0);
+  ASSERT_EQ("", sut3.GetFormattedValue());
+}
+} // namespace content