Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1219063014: Guard usage of kEnableMediaRouter with ENABLE_MEDIA_ROUTER (Closed)

Created:
5 years, 5 months ago by ckulakowski
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Guard usage of kEnableMediaRouter with ENABLE_MEDIA_ROUTER Definition of kEnableMediaRouter is guarded with ENABLE_MEDIA_ROUTER. All usages also should be guarded with this switch. Committed: https://crrev.com/089695d479511b8421b7119fbe8461933963d0b3 Cr-Commit-Position: refs/heads/master@{#348365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
ckulakowski
5 years, 5 months ago (2015-07-07 09:03:47 UTC) #2
Daniel Bratell
Drive-by ping!
5 years, 3 months ago (2015-09-11 07:58:58 UTC) #3
Marshall
LGTM but I'm not an OWNER
5 years, 3 months ago (2015-09-11 08:11:16 UTC) #4
fs
Trying a different Marshall (and a backup)
5 years, 3 months ago (2015-09-11 08:40:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219063014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1219063014/1
5 years, 3 months ago (2015-09-11 08:40:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 09:20:11 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/089695d479511b8421b7119fbe8461933963d0b3 Cr-Commit-Position: refs/heads/master@{#348365}
5 years, 3 months ago (2015-09-11 09:21:03 UTC) #10
mark a. foltz
LGTM Thanks for catching this.
5 years, 3 months ago (2015-09-11 16:04:52 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:20:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/089695d479511b8421b7119fbe8461933963d0b3
Cr-Commit-Position: refs/heads/master@{#348365}

Powered by Google App Engine
This is Rietveld 408576698