Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1219013007: [test] Fix redirect problem for downloading test data on windows. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix redirect problem for downloading test data on windows. BUG=v8:4254 LOG=n NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jkummerow@chromium.org Committed: https://crrev.com/e7330a644f9ea382244ecfadd245c50ffeb6f782 Cr-Commit-Position: refs/heads/master@{#29510}

Patch Set 1 #

Patch Set 2 : Review #

Patch Set 3 : Curl with python fallback. #

Patch Set 4 : Print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/testrunner/local/utils.py View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
PTAL
5 years, 5 months ago (2015-07-07 09:45:50 UTC) #2
Jakob Kummerow
Aren't workarounds awesome... LGTM.
5 years, 5 months ago (2015-07-07 10:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219013007/60001
5 years, 5 months ago (2015-07-07 10:35:20 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-07 10:35:32 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e7330a644f9ea382244ecfadd245c50ffeb6f782 Cr-Commit-Position: refs/heads/master@{#29510}
5 years, 5 months ago (2015-07-07 10:35:42 UTC) #8
tandrii(chromium)
5 years, 5 months ago (2015-07-10 21:11:58 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698