Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1218993004: Document strong mode (Closed)

Created:
5 years, 5 months ago by vsm
Modified:
5 years, 5 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Small correction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+477 lines, -0 lines) Patch
A STRONGMODE.md View 1 2 1 chunk +477 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
vsm
5 years, 5 months ago (2015-07-08 15:33:25 UTC) #2
vsm
5 years, 5 months ago (2015-07-08 15:34:00 UTC) #3
Jennifer Messerly
lgtm https://codereview.chromium.org/1218993004/diff/1/STRONGMODE.md File STRONGMODE.md (right): https://codereview.chromium.org/1218993004/diff/1/STRONGMODE.md#newcode19 STRONGMODE.md:19: This document provides a high-level overview of strong ...
5 years, 5 months ago (2015-07-08 15:44:02 UTC) #4
vsm
https://codereview.chromium.org/1218993004/diff/1/STRONGMODE.md File STRONGMODE.md (right): https://codereview.chromium.org/1218993004/diff/1/STRONGMODE.md#newcode19 STRONGMODE.md:19: This document provides a high-level overview of strong mode. ...
5 years, 5 months ago (2015-07-08 15:51:46 UTC) #5
Leaf
lgtm. https://codereview.chromium.org/1218993004/diff/20001/STRONGMODE.md File STRONGMODE.md (right): https://codereview.chromium.org/1218993004/diff/20001/STRONGMODE.md#newcode346 STRONGMODE.md:346: the runtime type is inferred as `List` in ...
5 years, 5 months ago (2015-07-08 20:15:20 UTC) #6
vsm
https://codereview.chromium.org/1218993004/diff/20001/STRONGMODE.md File STRONGMODE.md (right): https://codereview.chromium.org/1218993004/diff/20001/STRONGMODE.md#newcode346 STRONGMODE.md:346: the runtime type is inferred as `List` in order ...
5 years, 5 months ago (2015-07-08 20:18:08 UTC) #7
vsm
5 years, 5 months ago (2015-07-08 20:18:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
dbafa2e0a734d41cb664181c3927653285aec2be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698