Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: Source/core/animation/KeyframeEffectModel.cpp

Issue 1218943002: Compositor animations for Independent CSS Transform Properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add Manual Tests and fix bug with cancel tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/KeyframeEffectModel.h ('k') | Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/KeyframeEffectModel.cpp
diff --git a/Source/core/animation/KeyframeEffectModel.cpp b/Source/core/animation/KeyframeEffectModel.cpp
index b39b5de1dcc5eeb96b1e7f79d761ab151c63cc29..91e8b47c655acc0ddf27db0cddda0d3831307462 100644
--- a/Source/core/animation/KeyframeEffectModel.cpp
+++ b/Source/core/animation/KeyframeEffectModel.cpp
@@ -83,7 +83,7 @@ void KeyframeEffectModelBase::forceConversionsToAnimatableValues(Element& elemen
void KeyframeEffectModelBase::snapshotCompositableProperties(Element& element, const ComputedStyle* baseStyle)
{
ensureKeyframeGroups();
- for (CSSPropertyID id : CompositorAnimations::CompositableProperties) {
+ for (CSSPropertyID id : CompositorAnimations::compositableProperties) {
PropertyHandle property = PropertyHandle(id);
if (!affects(property))
continue;
@@ -154,6 +154,13 @@ KeyframeEffectModelBase::KeyframeVector KeyframeEffectModelBase::normalizedKeyfr
return result;
}
+bool KeyframeEffectModelBase::isTransformRelatedEffect() const
+{
+ return affects(PropertyHandle(CSSPropertyTransform))
+ || affects(PropertyHandle(CSSPropertyRotate))
+ || affects(PropertyHandle(CSSPropertyScale))
+ || affects(PropertyHandle(CSSPropertyTranslate));
+}
void KeyframeEffectModelBase::ensureKeyframeGroups() const
{
« no previous file with comments | « Source/core/animation/KeyframeEffectModel.h ('k') | Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698