Source/core/animation/CompositorAnimations.h - Issue 1218943002: Compositor animations for Independent CSS Transform Properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/CompositorAnimations.h

Issue 1218943002: Compositor animations for Independent CSS Transform Properties (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add Manual Tests and fix bug with cancel tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ManualTests/animation/compositor-transform-with-translate.html ('k') | Source/core/animation/CompositorAnimations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/CompositorAnimations.h

diff --git a/Source/core/animation/CompositorAnimations.h b/Source/core/animation/CompositorAnimations.h

index 0ba57ee8d040940cc8c7ac2eafc213710658645a..ab70192a027d0c405f644fa3c9a0303bf4b99748 100644

--- a/Source/core/animation/CompositorAnimations.h

+++ b/Source/core/animation/CompositorAnimations.h

@@ -47,8 +47,8 @@ class CORE_EXPORT CompositorAnimations {

public:

static CompositorAnimations* instance() { return instance(0); }

static void setInstanceForTesting(CompositorAnimations* newInstance) { instance(newInstance); }

- static bool isCompositableProperty(CSSPropertyID property) { return property == CSSPropertyOpacity || property == CSSPropertyTransform || property == CSSPropertyWebkitFilter; }

- static CSSPropertyID CompositableProperties[3];

+ static bool isCompositableProperty(CSSPropertyID);

+ static const CSSPropertyID compositableProperties[6];

virtual bool isCandidateForAnimationOnCompositor(const Timing&, const Element&, const Animation*, const EffectModel&, double animationPlaybackRate);

virtual void cancelIncompatibleAnimationsOnCompositor(const Element&, const Animation&, const EffectModel&);

« no previous file with comments | « ManualTests/animation/compositor-transform-with-translate.html ('k') | Source/core/animation/CompositorAnimations.cpp » ('j') | no next file with comments »