Compositor animations for Independent CSS Transform Properties

Source/core/animation/KeyframeEffect.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 119 matching lines @@
 }
 
 void KeyframeEffect::applyEffects()
 {
     ASSERT(isInEffect());
     ASSERT(animation());
     if (!m_target || !m_model)
         return;
 
     // Cancel composited animation of transform if a motion path, translate,
     // rotate or scale operation has been introduced on the element.

[dstockwell, 2015/07/03 01:58:41]

comment needs update

[soonm, 2015/07/03 06:34:29]

Done.

     if (m_target->computedStyle()
-        && (m_target->computedStyle()->hasMotionPath()
-            || m_target->computedStyle()->translate()
-            || m_target->computedStyle()->rotate()
-            || m_target->computedStyle()->scale())
+        && m_target->computedStyle()->hasMotionPath()
         && animation()->hasActiveAnimationsOnCompositor()
-        && animation()->affects(*m_target, CSSPropertyTransform)) {
+        && (animation()->affects(*m_target, CSSPropertyScale)
+            || animation()->affects(*m_target, CSSPropertyRotate)
+            || animation()->affects(*m_target, CSSPropertyTransform)
+            || animation()->affects(*m_target, CSSPropertyTranslate)))
         animation()->cancelAnimationOnCompositor();
-    }
 
     double iteration = currentIteration();
     ASSERT(iteration >= 0);
     OwnPtrWillBeRawPtr<WillBeHeapVector<RefPtrWillBeMember<Interpolation>>> interpolations = m_sampledEffect ? m_sampledEffect->mutableInterpolations() : nullptr;
     // FIXME: Handle iteration values which overflow int.
     m_model->sample(static_cast<int>(iteration), timeFraction(), iterationDuration(), interpolations);
     if (m_sampledEffect) {
         m_sampledEffect->setInterpolations(interpolations.release());
     } else if (interpolations && !interpolations->isEmpty()) {
         OwnPtrWillBeRawPtr<SampledEffect> sampledEffect = SampledEffect::create(this, interpolations.release());
@@ skipping 79 matching lines @@
     m_sampledEffect = nullptr;
     if (sampledEffect)
         sampledEffect->clear();
 }
 #endif
 
 bool KeyframeEffect::isCandidateForAnimationOnCompositor(double animationPlaybackRate) const
 {
     if (!model()
         || !m_target
-        || (m_target->computedStyle() && (m_target->computedStyle()->hasMotionPath() || m_target->computedStyle()->translate() || m_target->computedStyle()->rotate() || m_target->computedStyle()->scale())))
+        || (m_target->computedStyle() && m_target->computedStyle()->hasMotionPath()))
         return false;
 
+    // Do not put transforms on compositor if more than one of them are defined

[dstockwell, 2015/07/03 01:58:40]

I'm not sure the above is correct now (in applyEffects), does this work
correctly if we animate transform, then set the rotate property later?

[soonm, 2015/07/03 06:34:29]

Add tests to check for cancellations happening when new animation/style is added
with animating transform/translate/rotate/scale

+    // in computed style because they need to be explicitly ordered
+    if (m_target->computedStyle()) {
+        unsigned transformOperationsCount = 0;
+        if (m_target->computedStyle()->hasTransformOperations())
+            transformOperationsCount++;
+        if (m_target->computedStyle()->rotate())
+            transformOperationsCount++;
+        if (m_target->computedStyle()->scale())
+            transformOperationsCount++;
+        if (m_target->computedStyle()->translate())
+            transformOperationsCount++;
+        if (transformOperationsCount > 1)
+            return false;
+    }
+
     return CompositorAnimations::instance()->isCandidateForAnimationOnCompositor(specifiedTiming(), *m_target, animation(), *model(), animationPlaybackRate);
 }
 
 bool KeyframeEffect::maybeStartAnimationOnCompositor(int group, double startTime, double currentTime, double animationPlaybackRate)
 {
     ASSERT(!hasActiveAnimationsOnCompositor());
     if (!isCandidateForAnimationOnCompositor(animationPlaybackRate))
         return false;
     if (!CompositorAnimations::instance()->canStartAnimationOnCompositor(*m_target))
         return false;
@@ skipping 74 matching lines @@
 
 DEFINE_TRACE(KeyframeEffect)
 {
     visitor->trace(m_target);
     visitor->trace(m_model);
     visitor->trace(m_sampledEffect);
     AnimationEffect::trace(visitor);
 }
 
 } // namespace blink