Compositor animations for Independent CSS Transform Properties

Source/core/animation/CompositorAnimations.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 78 matching lines @@
         return Animation::hasLowerPriority(&animationToAdd, &animation);
     default:
         ASSERT_NOT_REACHED();
         return true;
     }
 }
 
 bool hasIncompatibleAnimations(const Element& targetElement, const Animation& animationToAdd, const EffectModel& effectToAdd)
 {
     const bool affectsOpacity = effectToAdd.affects(PropertyHandle(CSSPropertyOpacity));
-    const bool affectsTransform = effectToAdd.affects(PropertyHandle(CSSPropertyTransform));
+    const bool affectsTransform = effectToAdd.affects(PropertyHandle(CSSPropertyRotate))
+        || effectToAdd.affects(PropertyHandle(CSSPropertyScale))
+        || effectToAdd.affects(PropertyHandle(CSSPropertyTransform))

[dstockwell, 2015/07/03 01:53:23]

transform should be first (as most common)

[soonm, 2015/07/03 06:34:29]

Done.

+        || effectToAdd.affects(PropertyHandle(CSSPropertyTranslate));
     const bool affectsFilter = effectToAdd.affects(PropertyHandle(CSSPropertyWebkitFilter));
 
     if (!targetElement.hasAnimations())
         return false;
 
     ElementAnimations* elementAnimations = targetElement.elementAnimations();
     ASSERT(elementAnimations);
 
     for (const auto& entry : elementAnimations->animations()) {
         const Animation* attachedAnimation = entry.key;
         if (!considerAnimationAsIncompatible(*attachedAnimation, animationToAdd))
             continue;
 
         if ((affectsOpacity && attachedAnimation->affects(targetElement, CSSPropertyOpacity))
+            || (affectsTransform && attachedAnimation->affects(targetElement, CSSPropertyRotate))
+            || (affectsTransform && attachedAnimation->affects(targetElement, CSSPropertyScale))
             || (affectsTransform && attachedAnimation->affects(targetElement, CSSPropertyTransform))

[dstockwell, 2015/07/03 01:53:23]

transform should come first

[soonm, 2015/07/03 06:34:29]

Done - As well for the same code below.

+            || (affectsTransform && attachedAnimation->affects(targetElement, CSSPropertyTranslate))
             || (affectsFilter && attachedAnimation->affects(targetElement, CSSPropertyWebkitFilter)))
             return true;
     }
 
     return false;
 }
 
 }
 
-CSSPropertyID CompositorAnimations::CompositableProperties[3] = {
-    CSSPropertyOpacity, CSSPropertyTransform, CSSPropertyWebkitFilter
+bool CompositorAnimations::isCompositableProperty(CSSPropertyID property)
+{
+    for (CSSPropertyID id : compositableProperties) {
+        if (property == id)
+            return true;
+    }
+    return false;
+}
+
+const CSSPropertyID CompositorAnimations::compositableProperties[6] = {
+    CSSPropertyOpacity,
+    CSSPropertyRotate,
+    CSSPropertyScale,
+    CSSPropertyTransform,
+    CSSPropertyTranslate,
+    CSSPropertyWebkitFilter
 };
 
 bool CompositorAnimations::getAnimatedBoundingBox(FloatBox& box, const EffectModel& effect, double minValue, double maxValue) const
 {
     const KeyframeEffectModelBase& keyframeEffect = toKeyframeEffectModelBase(effect);
 
     PropertyHandleSet properties = keyframeEffect.properties();
 
     if (properties.isEmpty())
         return true;
 
     minValue = std::min(minValue, 0.0);
     maxValue = std::max(maxValue, 1.0);
 
     for (const auto& property : properties) {
         if (!property.isCSSProperty())
             continue;
 
         // TODO: Add the ability to get expanded bounds for filters as well.
-        if (property.cssProperty() != CSSPropertyTransform)
+        if (property.cssProperty() != CSSPropertyRotate
+            && property.cssProperty() != CSSPropertyScale
+            && property.cssProperty() != CSSPropertyTransform
+            && property.cssProperty() != CSSPropertyTranslate)
             continue;
 
         const PropertySpecificKeyframeVector& frames = keyframeEffect.getPropertySpecificKeyframes(property);
         if (frames.isEmpty() || frames.size() < 2)
             continue;
 
         FloatBox originalBox(box);
 
         for (size_t j = 0; j < frames.size() - 1; ++j) {
             const AnimatableTransform* startTransform = toAnimatableTransform(frames[j]->getAnimatableValue().get());
@@ skipping 37 matching lines @@
 // -----------------------------------------------------------------------
 
 bool CompositorAnimations::isCandidateForAnimationOnCompositor(const Timing& timing, const Element& targetElement, const Animation* animationToAdd, const EffectModel& effect, double animationPlaybackRate)
 {
     const KeyframeEffectModelBase& keyframeEffect = toKeyframeEffectModelBase(effect);
 
     PropertyHandleSet properties = keyframeEffect.properties();
     if (properties.isEmpty())
         return false;
 
+    unsigned transformOperationsCount = 0;

[dstockwell, 2015/07/03 01:58:40]

transformPropertyCount?

[soonm, 2015/07/03 06:34:29]

Yep that sounds better.

     for (const auto& property : properties) {
         if (!property.isCSSProperty())
             return false;
 
+        if (property.cssProperty() == CSSPropertyRotate

[loyso (OOO), 2015/07/03 03:50:07]

You have similar patterns repeated everywhere. Could we "extract common helper
method(s)" to avoid redundancy?

[soonm, 2015/07/03 06:34:29]

Did some clean up and abstracted out common checks.

+            || property.cssProperty() == CSSPropertyScale
+            || property.cssProperty() == CSSPropertyTransform
+            || property.cssProperty() == CSSPropertyTranslate)
+            transformOperationsCount++;
+
         const PropertySpecificKeyframeVector& keyframes = keyframeEffect.getPropertySpecificKeyframes(property);
         ASSERT(keyframes.size() >= 2);
         for (const auto& keyframe : keyframes) {
             // FIXME: Determine candidacy based on the CSSValue instead of a snapshot AnimatableValue.
             bool isNeutralKeyframe = keyframe->isCSSPropertySpecificKeyframe() && !toCSSPropertySpecificKeyframe(keyframe.get())->value() && keyframe->composite() == EffectModel::CompositeAdd;
             if ((keyframe->composite() != EffectModel::CompositeReplace && !isNeutralKeyframe) || !keyframe->getAnimatableValue())
                 return false;
 
             switch (property.cssProperty()) {
             case CSSPropertyOpacity:
                 break;
+            case CSSPropertyRotate:
+            case CSSPropertyScale:
+            case CSSPropertyTranslate:
             case CSSPropertyTransform:
                 if (toAnimatableTransform(keyframe->getAnimatableValue().get())->transformOperations().dependsOnBoxSize())
                     return false;
                 break;
             case CSSPropertyWebkitFilter: {
                 const FilterOperations& operations = toAnimatableFilterOperations(keyframe->getAnimatableValue().get())->operations();
                 if (operations.hasFilterThatMovesPixels())
                     return false;
                 break;
             }
             default:
                 // any other types are not allowed to run on compositor.
                 return false;
             }
         }
     }
 
+    // TODO: Support multiple transform property animations on the compositor
+    if (transformOperationsCount > 1)
+        return false;
+
     if (animationToAdd && hasIncompatibleAnimations(targetElement, *animationToAdd, effect))
         return false;
 
     CompositorAnimationsImpl::CompositorTiming out;
     if (!CompositorAnimationsImpl::convertTimingForCompositor(timing, 0, out, animationPlaybackRate))
         return false;
 
     return true;
 }
 
 void CompositorAnimations::cancelIncompatibleAnimationsOnCompositor(const Element& targetElement, const Animation& animationToAdd, const EffectModel& effectToAdd)
 {
     const bool affectsOpacity = effectToAdd.affects(PropertyHandle(CSSPropertyOpacity));
-    const bool affectsTransform = effectToAdd.affects(PropertyHandle(CSSPropertyTransform));
+    const bool affectsTransform = effectToAdd.affects(PropertyHandle(CSSPropertyRotate))
+        || effectToAdd.affects(PropertyHandle(CSSPropertyScale))
+        || effectToAdd.affects(PropertyHandle(CSSPropertyTransform))

[dstockwell, 2015/07/03 01:58:40]

transform first

[soonm, 2015/07/03 06:34:29]

Done.

+        || effectToAdd.affects(PropertyHandle(CSSPropertyTranslate));
     const bool affectsFilter = effectToAdd.affects(PropertyHandle(CSSPropertyWebkitFilter));
 
     if (!targetElement.hasAnimations())
         return;
 
     ElementAnimations* elementAnimations = targetElement.elementAnimations();
     ASSERT(elementAnimations);
 
     for (const auto& entry : elementAnimations->animations()) {
         Animation* attachedAnimation = entry.key;
         if (!considerAnimationAsIncompatible(*attachedAnimation, animationToAdd))
             continue;
 
         if ((affectsOpacity && attachedAnimation->affects(targetElement, CSSPropertyOpacity))
+            || (affectsTransform && attachedAnimation->affects(targetElement, CSSPropertyRotate))
+            || (affectsTransform && attachedAnimation->affects(targetElement, CSSPropertyScale))
             || (affectsTransform && attachedAnimation->affects(targetElement, CSSPropertyTransform))

[dstockwell, 2015/07/03 01:58:40]

transform first

[soonm, 2015/07/03 06:34:29]

Done.

+            || (affectsTransform && attachedAnimation->affects(targetElement, CSSPropertyTranslate))
             || (affectsFilter && attachedAnimation->affects(targetElement, CSSPropertyWebkitFilter)))
             attachedAnimation->cancelAnimationOnCompositor();
     }
 }
 
 bool CompositorAnimations::canStartAnimationOnCompositor(const Element& element)
 {
     return element.layoutObject() && element.layoutObject()->compositingState() == PaintsIntoOwnBacking;
 }
 
@@ skipping 349 matching lines @@
             break;
         }
         case CSSPropertyWebkitFilter: {
             targetProperty = WebCompositorAnimation::TargetPropertyFilter;
             WebFilterAnimationCurve* filterCurve = Platform::current()->compositorSupport()->createFilterAnimationCurve();
             addKeyframesToCurve(*filterCurve, values, timing);
             setTimingFunctionOnCurve(*filterCurve, timing.timingFunction.get());
             curve = adoptPtr(filterCurve);
             break;
         }
+        case CSSPropertyRotate:
+        case CSSPropertyScale:
+        case CSSPropertyTranslate:
         case CSSPropertyTransform: {
             targetProperty = WebCompositorAnimation::TargetPropertyTransform;
             WebTransformAnimationCurve* transformCurve = Platform::current()->compositorSupport()->createTransformAnimationCurve();
             addKeyframesToCurve(*transformCurve, values, timing);
             setTimingFunctionOnCurve(*transformCurve, timing.timingFunction.get());
             curve = adoptPtr(transformCurve);
             break;
         }
         default:
             ASSERT_NOT_REACHED();
@@ skipping 43 matching lines @@
             break;
         default:
             ASSERT_NOT_REACHED();
         }
         animations.append(animation.release());
     }
     ASSERT(!animations.isEmpty());
 }
 
 } // namespace blink