Issue 121893003: Correctly handle instances without elements in polymorphic keyed load/store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 121893003: Correctly handle instances without elements in polymorphic keyed load/store. (Closed)

Created:
6 years, 11 months ago by ulan

Modified:
6 years, 11 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Correctly handle instances without elements in polymorphic keyed load/store. BUG=331416 TEST=mjsunit/regress/regress-331416.js LOG=Y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18484

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -17 lines)			Patch
	M	src/stub-cache.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-331416.js	View	1 2	2 chunks	+21 lines, -17 lines	0 comments	Download

Total messages: 5 (0 generated)

Toon Verwaest

Please write a test verifying that this also works properly after optimizing the code using ...

6 years, 11 months ago (2014-01-07 15:34:56 UTC) #2

ulan

On 2014/01/07 15:34:56, Toon Verwaest wrote: > Please write a test verifying that this also ...

6 years, 11 months ago (2014-01-07 16:04:06 UTC) #3

ulan

6 years, 11 months ago (2014-01-08 09:57:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r18484 (presubmit successful).