third_party/libpng/libpng.gyp - Issue 1218903002: win clang: don't disable -Wself-assign

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libpng/libpng.gyp

Issue 1218903002: win clang: don't disable -Wself-assign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix lzma_sdk and libpng for gn build Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libpng/libpng.gyp

diff --git a/third_party/libpng/libpng.gyp b/third_party/libpng/libpng.gyp

index ac8fdb41c929c38ac8d85fbf2adf7efdc753ffd9..48b3fa409c24e80d9df8e0c4623f634943c8de82 100644

--- a/third_party/libpng/libpng.gyp

+++ b/third_party/libpng/libpng.gyp

@@ -9,6 +9,10 @@

'dependencies': [

'../zlib/zlib.gyp:zlib',

+ 'variables': {

+ # Upstream uses self-assignment to avoid warnings.

+ 'clang_warning_flags': [ '-Wno-self-assign' ]

+ },

'defines': [

'CHROME_PNG_WRITE_SUPPORT',

'PNG_USER_CONFIG',

@@ -67,7 +71,7 @@

'defines': [

'PNG_USE_DLL',

- },

+ },

}],

['OS=="android"', {

'toolsets': ['target', 'host'],

« no previous file with comments | « third_party/libpng/BUILD.gn ('k') | third_party/libxml/README.chromium » ('j') | no next file with comments »