Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1218903002: win clang: don't disable -Wself-assign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix lzma_sdk and libpng for gn build Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 18d20d987a2ca82c9e64099c8cfd20f18314390a..98826fe29e8dd498bf626439759b8ce1e9cc9813 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -819,7 +819,6 @@ if (is_win) {
"-Wno-pointer-sign", # http://crbug.com/505303
"-Wno-reorder", # http://crbug.com/505304
"-Wno-return-type-c-linkage", # http://crbug.com/505305
- "-Wno-self-assign", # http://crbug.com/505306
"-Wno-sometimes-uninitialized", # http://crbug.com/505307
"-Wno-switch", # http://crbug.com/505308
"-Wno-tautological-compare", # http://crbug.com/505309
« no previous file with comments | « build/common.gypi ('k') | third_party/libpng/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698