Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: third_party/lzma_sdk/BUILD.gn

Issue 1218903002: win clang: don't disable -Wself-assign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix lzma_sdk and libpng for gn build Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/libxml/src/xmlschemas.c ('k') | third_party/lzma_sdk/lzma_sdk.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("lzma_sdk_config") { 5 config("lzma_sdk_config") {
6 include_dirs = [ "." ] 6 include_dirs = [ "." ]
7 } 7 }
8 8
9 static_library("lzma_sdk") { 9 static_library("lzma_sdk") {
10 sources = [ 10 sources = [
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 defines = [ 47 defines = [
48 "_7ZIP_ST", 48 "_7ZIP_ST",
49 "_LZMA_PROB32", 49 "_LZMA_PROB32",
50 ] 50 ]
51 51
52 configs -= [ "//build/config/compiler:chromium_code" ] 52 configs -= [ "//build/config/compiler:chromium_code" ]
53 configs += [ "//build/config/compiler:no_chromium_code" ] 53 configs += [ "//build/config/compiler:no_chromium_code" ]
54 54
55 public_configs = [ ":lzma_sdk_config" ] 55 public_configs = [ ":lzma_sdk_config" ]
56
57 # Must be in a config because of how GN orders flags (otherwise -Wall will
58 # appear after this, and turn it back on).
59 config("clang_warnings") {
60 if (is_clang) {
61 # Upstream uses self-assignment to avoid warnings.
62 cflags = [ "-Wno-self-assign" ]
63 }
64 }
65 configs += [ ":clang_warnings" ]
56 } 66 }
OLDNEW
« no previous file with comments | « third_party/libxml/src/xmlschemas.c ('k') | third_party/lzma_sdk/lzma_sdk.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698