Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2025)

Side by Side Diff: third_party/libpng/BUILD.gn

Issue 1218903002: win clang: don't disable -Wself-assign (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix lzma_sdk and libpng for gn build Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | third_party/libpng/libpng.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("libpng_config") { 5 config("libpng_config") {
6 include_dirs = [ "." ] 6 include_dirs = [ "." ]
7 7
8 defines = [ 8 defines = [
9 "CHROME_PNG_WRITE_SUPPORT", 9 "CHROME_PNG_WRITE_SUPPORT",
10 "PNG_USER_CONFIG", 10 "PNG_USER_CONFIG",
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 54
55 if (is_win && is_component_build) { 55 if (is_win && is_component_build) {
56 defines = [ "PNG_BUILD_DLL" ] 56 defines = [ "PNG_BUILD_DLL" ]
57 } 57 }
58 58
59 public_configs = [ ":libpng_config" ] 59 public_configs = [ ":libpng_config" ]
60 60
61 public_deps = [ 61 public_deps = [
62 "//third_party/zlib", 62 "//third_party/zlib",
63 ] 63 ]
64
65 # Must be in a config because of how GN orders flags (otherwise -Wall will
66 # appear after this, and turn it back on).
67 config("clang_warnings") {
68 if (is_clang) {
69 # Upstream uses self-assignment to avoid warnings.
70 cflags = [ "-Wno-self-assign" ]
71 }
72 }
73 configs += [ ":clang_warnings" ]
64 } 74 }
65 75
66 if (is_win) { 76 if (is_win) {
67 component("libpng") { 77 component("libpng") {
68 public_deps = [ 78 public_deps = [
69 ":libpng_sources", 79 ":libpng_sources",
70 ] 80 ]
71 } 81 }
72 } else { 82 } else {
73 group("libpng") { 83 group("libpng") {
74 public_deps = [ 84 public_deps = [
75 ":libpng_sources", 85 ":libpng_sources",
76 ] 86 ]
77 } 87 }
78 } 88 }
OLDNEW
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | third_party/libpng/libpng.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698