chrome/common/extensions/extension.cc - Issue 12189018: <webview>: Implement WebRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 12189018: <webview>: Implement WebRequest API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Support all events Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index be43f6cce133726f6d76c65baf12f8773420f9b2..f832b4cccad7743e9609b0a7d1c6927f711de7a6 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -2962,11 +2962,12 @@ bool Extension::CheckPlatformAppFeatures(std::string* utf8_error) const {

}

bool Extension::CheckConflictingFeatures(std::string* utf8_error) const {

- if (has_lazy_background_page() &&

- HasAPIPermission(APIPermission::kWebRequest)) {

- *utf8_error = errors::kWebRequestConflictsWithLazyBackground;

- return false;

- }

+ // TODO(fsamuel): What to do here?

+ //if (has_lazy_background_page() &&

+ // HasAPIPermission(APIPermission::kWebRequest)) {

+ // *utf8_error = errors::kWebRequestConflictsWithLazyBackground;

+ // return false;

+ //}

return true;

}