chrome/browser/extensions/extension_process_manager.cc - Issue 12189018: <webview>: Implement WebRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_process_manager.cc

Issue 12189018: <webview>: Implement WebRequest API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Diff from latest patch Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_process_manager.cc

diff --git a/chrome/browser/extensions/extension_process_manager.cc b/chrome/browser/extensions/extension_process_manager.cc

index 0163e798347de9f2c625575530dcb781a383a710..3660ca804119ca01ec98492ee8d94b86428b620b 100644

--- a/chrome/browser/extensions/extension_process_manager.cc

+++ b/chrome/browser/extensions/extension_process_manager.cc

@@ -451,7 +451,9 @@ int ExtensionProcessManager::DecrementLazyKeepaliveCount(

return 0;

int& count = background_page_data_[extension->id()].lazy_keepalive_count;

- DCHECK_GT(count, 0);

+ // TODO(fsamuel): What to do here? This fires when using WebRequests in

+ // <webview>.

Matt Perry 2013/02/06 22:40:24 That's not good. These refcount errors are not fun

Fady Samuel 2013/05/15 21:58:53 Fixed. Calling IncrementInFlightEventsOnUI in Even

+ //DCHECK_GT(count, 0);

if (--count == 0) {

MessageLoop::current()->PostDelayedTask(

FROM_HERE,