[turbofan] Context specialization is the job of the JSContextSpecialization.

[turbofan] Context specialization is the job of the JSContextSpecialization.

Remove the context specialization hack from the AstGraphBuilder, and
properly specialize to the function context in the context specialization.
And replace the correct context in the JSInliner.

R=mstarzinger@chromium.org
BUG=v8:4273
LOG=n

Committed: https://crrev.com/069a47f6e5ed00d0f63fc845b62ad325f13b2c37
Cr-Commit-Position: refs/heads/master@{#29493}

[Benedikt Meurer, 2015-06-30 12:42:48]

Hey Michi,

Here's the CL you're asking for. Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2015-06-30 12:48:44]

LGTM. I love it. Thank you!

https://codereview.chromium.org/1218873005/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.h (right):

https://codereview.chromium.org/1218873005/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.h:38: bool CreateGraph(bool stack_check = true);
Woot! I love this!

[Michael Starzinger, 2015-06-30 12:48:48]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-06-30 12:48:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218873005/1

[commit-bot: I haz the power, 2015-06-30 13:42:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-30 13:42:27]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7191)

[Benedikt Meurer, 2015-07-01 04:11:06]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-07-01 04:11:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218873005/1

[Benedikt Meurer, 2015-07-01 04:12:34]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2015-07-01 04:16:55]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-07-01 04:17:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218873005/1

[Benedikt Meurer, 2015-07-01 04:28:23]

The CQ bit was unchecked by bmeurer@chromium.org

[Michael Starzinger, 2015-07-06 12:30:45]

Still LGTM. Still love it.

https://codereview.chromium.org/1218873005/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1218873005/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:534: Node* inner_context =
BuildLocalFunctionContext(function_context_.get());
nit: We could use GetFunctionContext() here as well.

[Benedikt Meurer, 2015-07-06 12:33:38]

https://codereview.chromium.org/1218873005/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1218873005/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:534: Node* inner_context =
BuildLocalFunctionContext(function_context_.get());
On 2015/07/06 12:30:45, Michael Starzinger wrote:
> nit: We could use GetFunctionContext() here as well.

Done.

[Benedikt Meurer, 2015-07-06 12:33:43]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-07-06 12:33:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1218873005/#ps40001
(title: "Fix mini-nit.")

[commit-bot: I haz the power, 2015-07-06 12:33:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218873005/40001

[commit-bot: I haz the power, 2015-07-06 12:56:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-06 12:56:38]

Patchset 3 (id:??) landed as
https://crrev.com/069a47f6e5ed00d0f63fc845b62ad325f13b2c37
Cr-Commit-Position: refs/heads/master@{#29493}