Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1218873002: Layout tests: unflake console tests that race with the main resource load. (Closed)

Created:
5 years, 5 months ago by pfeldman
Modified:
5 years, 5 months ago
Reviewers:
sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Layout tests: unflake console tests that race with the main resource load. BUG=498539 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -196 lines) Patch
M LayoutTests/inspector/console/console-assert.html View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-assert-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-copy-treeoutline.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-copy-treeoutline-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-dir.html View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-dir-expected.txt View 4 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/inspector/console/console-filter-level-test.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-filter-level-test-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M LayoutTests/inspector/console/console-format.html View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format-array-prototype.html View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format-array-prototype-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M LayoutTests/inspector/console/console-format-expected.txt View 9 chunks +88 lines, -88 lines 0 comments Download
M LayoutTests/inspector/console/console-format-style-whitelist.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-format-style-whitelist-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/inspector/console/console-log-linkify-stack-in-errors.html View 2 chunks +5 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt View 3 chunks +61 lines, -47 lines 0 comments Download
M LayoutTests/inspector/console/console-repeat-count.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-repeat-count-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-search.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-viewport-selection.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-viewport-selection-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-xml-document.html View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-xml-document-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1212153003 Patch 40001

Messages

Total messages: 6 (2 generated)
pfeldman
5 years, 5 months ago (2015-06-29 16:21:02 UTC) #2
sergeyv
lgtm
5 years, 5 months ago (2015-06-30 09:22:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218873002/1
5 years, 5 months ago (2015-06-30 12:31:05 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 14:11:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198056

Powered by Google App Engine
This is Rietveld 408576698