Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1218863005: don't fix winding for empty paths (Closed)

Created:
5 years, 5 months ago by caryclark
Modified:
5 years, 5 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

don't fix winding for empty paths A path can be non-empty but become empty when it is simplified. For instance, a path with the same rectangle, twice, with opposite windings. No contours are created for empty paths, so don't try to fix their winding direction. Additionally, check for a NULL coincidence since the OpBuilder assumes that no concidence edges can be present after the paths are simplified. This code should not get called, but it's worth the future-proofing to check. R=fmalita@chromium.org BUG=502792 Committed: https://skia.googlesource.com/skia/+/218f21ac09c70b98a10cb8e1999b85a22fa0b151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M src/pathops/SkOpBuilder.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218863005/1
5 years, 5 months ago (2015-06-29 18:34:47 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-06-29 18:34:48 UTC) #3
f(malita)
lgtm
5 years, 5 months ago (2015-06-29 18:35:53 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 18:41:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/218f21ac09c70b98a10cb8e1999b85a22fa0b151

Powered by Google App Engine
This is Rietveld 408576698