Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1218843002: Revert "Support disabling unit test batching. Use it for angle_end2end_tests" (Closed)

Created:
5 years, 5 months ago by Stephen White
Modified:
5 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Support disabling unit test batching. Use it for angle_end2end_tests" This reverts commit 915c316c3431e193be1b025c557b5eee557e22d0. This change seems to be breaking the angle_end2end_tests on Windows GPU FYI bots: http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29 http://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29 http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28ATI%29 http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20dEQP%20%28NVIDIA%29 e.g., [1/949] EGLSurfaceTest.MessageLoopBug (UNKNOWN) [2/949] EGLSurfaceTest.MessageLoopBugContext (UNKNOWN) [3/949] EGLSurfaceTest.MakeCurrentTwice (UNKNOWN) [4/949] EGLSurfaceTest.ResizeD3DWindow (UNKNOWN) ... http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/16863/steps/angle_end2end_tests/logs/stdio BUG=501604 TBR=phadjanjr@chromium.org,geofflang@chromium.org Committed: https://crrev.com/9dbed546384c617954e36ac755f1786de59fae3b Cr-Commit-Position: refs/heads/master@{#336559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -54 lines) Patch
M base/test/launcher/unit_test_launcher.h View 1 chunk +0 lines, -13 lines 0 comments Download
M base/test/launcher/unit_test_launcher.cc View 5 chunks +9 lines, -37 lines 0 comments Download
M gpu/angle_end2end_tests_main.cc View 1 chunk +1 line, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218843002/1
5 years, 5 months ago (2015-06-29 13:55:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 14:54:40 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 14:55:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dbed546384c617954e36ac755f1786de59fae3b
Cr-Commit-Position: refs/heads/master@{#336559}

Powered by Google App Engine
This is Rietveld 408576698