Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1218823006: Revert of [Telemetry] Remove adb_commands usage from android_device (Closed)

Created:
5 years, 5 months ago by nednguyen
Modified:
5 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, telemetry-reviews_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Remove adb_commands usage from android_device (patchset #4 id:90001 of https://codereview.chromium.org/1211323004/) Reason for revert: Speculative revert as this may break broke telemetry perf android tests (http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/20964) Original issue's description: > [Telemetry] Remove adb_commands usage from android_device > > Reland of https://codereview.chromium.org/1212643002/ > > This time, we don't use DeviceUtils.HealthyDevices() API to make sure that all > connected devices are processed instead of only healthy devices. This is to make > sure that the cq bots have enough capacity to handle the unittests load since > some of the android bots used by CQ are marked unhealthy. > > BUG=476709 > > Committed: https://crrev.com/d5bb872d537153753f930eab6097afb315612274 > Cr-Commit-Position: refs/heads/master@{#337099} TBR=jbudorick@chromium.org BUG=476709 Committed: https://crrev.com/8df2841213f300c7d72c9f20eb913f1c4a1c1f49 Cr-Commit-Position: refs/heads/master@{#337159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -109 lines) Patch
M tools/telemetry/telemetry/core/platform/android_device.py View 6 chunks +15 lines, -27 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_device_unittest.py View 1 chunk +96 lines, -82 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
nednguyen
Created Revert of [Telemetry] Remove adb_commands usage from android_device
5 years, 5 months ago (2015-07-02 01:25:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218823006/1
5 years, 5 months ago (2015-07-02 01:26:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 02:30:51 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 02:31:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8df2841213f300c7d72c9f20eb913f1c4a1c1f49
Cr-Commit-Position: refs/heads/master@{#337159}

Powered by Google App Engine
This is Rietveld 408576698