Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: src/lookup.cc

Issue 1218813012: Cleanup Delete backend implementation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/elements.cc ('K') | « src/lookup.h ('k') | src/messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index 716622b475de66d098dfa587ad8b467f47d01f6d..1b2d35e335344275c534bbe8a4a371edb0452552 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -228,6 +228,28 @@ void LookupIterator::ApplyTransitionToDataProperty() {
}
+void LookupIterator::Delete() {
+ Handle<JSObject> holder = Handle<JSObject>::cast(holder_);
+ if (IsElement()) {
+ ElementsAccessor* accessor = holder->GetElementsAccessor();
+ accessor->Delete(holder, number_);
+ } else {
+ PropertyNormalizationMode mode = holder->map()->is_prototype_map()
+ ? KEEP_INOBJECT_PROPERTIES
+ : CLEAR_INOBJECT_PROPERTIES;
+
+ if (holder->HasFastProperties()) {
+ JSObject::NormalizeProperties(holder, mode, 0, "DeletingProperty");
+ holder_map_ = handle(holder->map(), isolate_);
+ ReloadPropertyInformation();
+ }
+ // TODO(verwaest): Get rid of the name_ argument.
+ JSObject::DeleteNormalizedProperty(holder, name_, number_);
+ JSObject::ReoptimizeIfPrototype(holder);
Igor Sheludko 2015/07/03 15:09:02 Shouldn't you call NotFound() here?
+ }
+}
+
+
void LookupIterator::TransitionToAccessorProperty(
AccessorComponent component, Handle<Object> accessor,
PropertyAttributes attributes) {
« src/elements.cc ('K') | « src/lookup.h ('k') | src/messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698