Cleanup Delete backend implementation.

Cleanup Delete backend implementation.

BUG=v8:4137
LOG=n

Committed: https://crrev.com/dba715ec6ad7557c2d40ebb021721731c462f70b
Cr-Commit-Position: refs/heads/master@{#29477}

[Toon Verwaest, 2015-07-02 10:54:38]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-07-02 10:54:39]

ptal

[Igor Sheludko, 2015-07-03 15:09:02]

lgtm with suggestions:

https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc#newcode...
src/elements.cc:1002: if (obj->elements() != *store) {
It looks like you can do the same trick to unify AddImpl() for
DictionaryElementsAccessor and SlowSloppyArgumentsElementsAccessor.

Or even better if you split the addition/deletion into parts - update the
elements dictionary and then set it into the object.

https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc#newcode...
src/elements.cc:1010: virtual void Delete(Handle<JSObject> obj, uint32_t index)
final {
Could you please move this virtual Delete() implementation to
ElementsAccessorBase class and in all the successors replace virtual Delete()
with static DeleteImpl()? Like we do for virtual Get()/static GetImpl() and etc.
Just to be uniform.

https://codereview.chromium.org/1218813012/diff/60001/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/1218813012/diff/60001/src/lookup.cc#newcode248
src/lookup.cc:248: JSObject::ReoptimizeIfPrototype(holder);
Shouldn't you call NotFound() here?

[Igor Sheludko, 2015-07-03 16:02:01]

lgtm

[Toon Verwaest, 2015-07-03 16:16:54]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-07-03 16:17:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218813012/100001

[commit-bot: I haz the power, 2015-07-03 16:17:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-03 16:17:56]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7328)
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7282)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/7406)

(exceeded global retry quota)

[Toon Verwaest, 2015-07-06 08:28:40]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-07-06 08:28:40]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1218813012/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-07-06 08:28:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218813012/120001

[commit-bot: I haz the power, 2015-07-06 08:53:46]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-07-06 08:54:01]

Patchset 7 (id:??) landed as
https://crrev.com/dba715ec6ad7557c2d40ebb021721731c462f70b
Cr-Commit-Position: refs/heads/master@{#29477}