Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1218803006: Add a flag for legacy const semantics (Closed)

Created:
5 years, 5 months ago by arv (Not doing code reviews)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a flag for legacy const semantics This flag is on by default but it will allow us to turn that off in favor of harmony-sloppy in the future. BUG=v8:3305, v8:2198 LOG=N R=littledan@chromium.org, rossberg@chromium.org Committed: https://crrev.com/3973642c98501b3fc5a38c7cde6a908c15222edc Cr-Commit-Position: refs/heads/master@{#29526}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add message tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -25 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parser.cc View 7 chunks +15 lines, -10 lines 0 comments Download
M src/preparser.h View 4 chunks +8 lines, -1 line 0 comments Download
M src/preparser.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +29 lines, -1 line 0 comments Download
A + test/message/no-legacy-const.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
A test/message/no-legacy-const.out View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + test/message/no-legacy-const-2.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
A test/message/no-legacy-const-2.out View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + test/message/no-legacy-const-3.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
A test/message/no-legacy-const-3.out View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
arv (Not doing code reviews)
WDYT? The idea is to make harmony-sloppy cover let and const but that legacy-const has ...
5 years, 5 months ago (2015-07-06 21:08:36 UTC) #1
Dan Ehrenberg
I like this change; my only concern is our behavior in sloppy mode when the ...
5 years, 5 months ago (2015-07-06 21:26:12 UTC) #2
arv (Not doing code reviews)
If this flag is false we should report something like "unexpected token const". Let me ...
5 years, 5 months ago (2015-07-06 21:32:16 UTC) #3
arv (Not doing code reviews)
https://codereview.chromium.org/1218803006/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1218803006/diff/1/src/parser.cc#newcode1385 src/parser.cc:1385: } On 2015/07/06 21:26:12, Dan Ehrenberg wrote: > Do ...
5 years, 5 months ago (2015-07-06 21:35:25 UTC) #4
arv (Not doing code reviews)
Add message tests
5 years, 5 months ago (2015-07-06 21:41:51 UTC) #5
Dan Ehrenberg
lgtm
5 years, 5 months ago (2015-07-06 22:06:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218803006/20001
5 years, 5 months ago (2015-07-07 15:14:03 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-07 15:50:21 UTC) #10
adamk
I have a similar concern to Dan's, I think: are we ever going to turn ...
5 years, 5 months ago (2015-07-07 20:55:47 UTC) #12
arv (Not doing code reviews)
On 2015/07/07 20:55:47, adamk wrote: > I have a similar concern to Dan's, I think: ...
5 years, 5 months ago (2015-07-07 21:22:17 UTC) #13
adamk
lgtm
5 years, 5 months ago (2015-07-07 21:55:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218803006/20001
5 years, 5 months ago (2015-07-07 21:55:39 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-07 21:57:15 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 21:57:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3973642c98501b3fc5a38c7cde6a908c15222edc
Cr-Commit-Position: refs/heads/master@{#29526}

Powered by Google App Engine
This is Rietveld 408576698