chrome/browser/autofill/autofill_manager.cc - Issue 12188020: Adding the page and DPI scale adjustment for Autofill Popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 12188020: Adding the page and DPI scale adjustment for Autofill Popups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed Ted's nits Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autofill/autofill_manager.cc

diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc

index b395f5498d67104b4ec1a8badeb5f1f953a73461..be95d5aa95365a53168c75b445371d3508d28471 100644

--- a/chrome/browser/autofill/autofill_manager.cc

+++ b/chrome/browser/autofill/autofill_manager.cc

@@ -497,7 +497,7 @@ void AutofillManager::OnTextFieldDidChange(const FormData& form,

void AutofillManager::OnQueryFormFieldAutofill(int query_id,

const FormData& form,

const FormFieldData& field,

- const gfx::Rect& bounding_box,

+ const gfx::RectF& bounding_box,

bool display_warning) {

std::vector<string16> values;

std::vector<string16> labels;

@@ -813,7 +813,7 @@ void AutofillManager::OnAddPasswordFormMapping(

void AutofillManager::OnShowPasswordSuggestions(

const FormFieldData& field,

- const gfx::Rect& bounds,

+ const gfx::RectF& bounds,

const std::vector<string16>& suggestions) {

if (external_delegate_)

external_delegate_->OnShowPasswordSuggestions(suggestions, field, bounds);