Adding the page and DPI scale adjustment for Autofill Popups.

chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/test_autofill_external_delegate.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 18 matching lines @@
       {}
   virtual void ClearPreviewedForm() OVERRIDE {}
 
   MOCK_METHOD0(ControllerDestroyed, void());
 };
 
 class TestAutofillPopupController : public AutofillPopupControllerImpl {
  public:
   explicit TestAutofillPopupController(
       AutofillExternalDelegate* external_delegate,
-      const gfx::Rect& element_bounds)
+      const gfx::RectF& element_bounds)
       : AutofillPopupControllerImpl(external_delegate, NULL, element_bounds) {}
   virtual ~TestAutofillPopupController() {}
 
   void set_display(const gfx::Display display) {
     display_ = display;
   }
   virtual gfx::Display GetDisplayNearestPoint(const gfx::Point& point) const
       OVERRIDE {
     return display_;
   }
@@ skipping 19 matching lines @@
   }
   bool RemoveSelectedLine() {
     return AutofillPopupControllerImpl::RemoveSelectedLine();
   }
   void DoHide() {
     AutofillPopupControllerImpl::Hide();
   }
   const gfx::Rect& popup_bounds() const {
     return AutofillPopupControllerImpl::popup_bounds();
   }
-  const gfx::Rect& element_bounds() const {
+  const gfx::RectF& element_bounds() const {
     return AutofillPopupControllerImpl::element_bounds();
   }
 #if !defined(OS_ANDROID)
   const gfx::Font& name_font() const {
     return AutofillPopupControllerImpl::name_font();
   }
   const gfx::Font& subtext_font() const {
     return AutofillPopupControllerImpl::subtext_font();
   }
 #endif
@@ skipping 183 matching lines @@
           NULL,
           gfx::Rect());
   EXPECT_EQ(controller, controller2);
   controller->Hide();
 
   testing::NiceMock<TestAutofillPopupController>* test_controller =
       new testing::NiceMock<TestAutofillPopupController>(&delegate,
                                                          gfx::Rect());
   EXPECT_CALL(*test_controller, Hide());
 
-  gfx::Rect bounds(0, 0, 1, 2);
+  gfx::RectF bounds(0.f, 0.f, 1.f, 2.f);
   AutofillPopupControllerImpl* controller3 =
       AutofillPopupControllerImpl::GetOrCreate(
           test_controller,
           &delegate,
           NULL,
           bounds);
   EXPECT_EQ(
       bounds,
       static_cast<AutofillPopupController*>(controller3)->element_bounds());
   controller3->Hide();
@@ skipping 43 matching lines @@
   autofill_popup_controller_->Show(names, names, names, autofill_ids);
   int desired_width = autofill_popup_controller_->GetDesiredPopupWidth();
   int desired_height = autofill_popup_controller_->GetDesiredPopupHeight();
 
   // Setup the visible screen space.
   gfx::Display display(0, gfx::Rect(0, 0,
                                     desired_width * 2, desired_height * 2));
 
   // Store the possible element bounds and the popup bounds they should result
   // in.
-  std::vector<gfx::Rect> element_bounds;
+  std::vector<gfx::RectF> element_bounds;
   std::vector<gfx::Rect> expected_popup_bounds;
 
   // The popup grows down and to the right.
-  element_bounds.push_back(gfx::Rect(0, 0, 0, 0));
+  element_bounds.push_back(gfx::RectF(0, 0, 0, 0));
   expected_popup_bounds.push_back(
       gfx::Rect(0, 0, desired_width, desired_height));
 
   // The popup grows down and to the left.
-  element_bounds.push_back(gfx::Rect(2 * desired_width, 0, 0, 0));
+  element_bounds.push_back(gfx::RectF(2 * desired_width, 0, 0, 0));
   expected_popup_bounds.push_back(
       gfx::Rect(desired_width, 0, desired_width, desired_height));
 
   // The popup grows up and to the right.
-  element_bounds.push_back(gfx::Rect(0, 2 * desired_height, 0, 0));
+  element_bounds.push_back(gfx::RectF(0, 2 * desired_height, 0, 0));
   expected_popup_bounds.push_back(
       gfx::Rect(0, desired_height, desired_width, desired_height));
 
   // The popup grows up and to the left.
   element_bounds.push_back(
-      gfx::Rect(2 * desired_width, 2 * desired_height, 0, 0));
+      gfx::RectF(2 * desired_width, 2 * desired_height, 0, 0));
   expected_popup_bounds.push_back(
       gfx::Rect(desired_width, desired_height, desired_width, desired_height));
 
   // The popup would be partial off the top and left side of the screen.
   element_bounds.push_back(
-      gfx::Rect(-desired_width / 2, -desired_height / 2, 0, 0));
+      gfx::RectF(-desired_width / 2, -desired_height / 2, 0, 0));
   expected_popup_bounds.push_back(
       gfx::Rect(0, 0, desired_width, desired_height));
 
   // The popup would be partially off the bottom and the right side of
   // the screen.
   element_bounds.push_back(
-      gfx::Rect(desired_width * 1.5, desired_height * 1.5, 0, 0));
+      gfx::RectF(desired_width * 1.5, desired_height * 1.5, 0, 0));
   expected_popup_bounds.push_back(gfx::Rect(
           desired_width / 2, desired_height /2, desired_width, desired_height));
 
   for (size_t i = 0; i < element_bounds.size(); ++i) {
     TestAutofillPopupController autofill_popup_controller(&external_delegate_,
                                                           element_bounds[i]);
     autofill_popup_controller.set_display(display);
     autofill_popup_controller.Show(names, names, names, autofill_ids);
 
     EXPECT_EQ(expected_popup_bounds[i].ToString(),
               autofill_popup_controller.popup_bounds().ToString()) <<
         "Popup bounds failed to match for test " << i;
   }
 }