Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1218783003: Revert of Revert of content: Fix single process support for native GpuMemoryBuffers. (Closed)

Created:
5 years, 5 months ago by grt (UTC plus 2)
Modified:
5 years, 5 months ago
Reviewers:
kcarattini, reveman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, vignatti (out of this project)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of content: Fix single process support for native GpuMemoryBuffers. (patchset #1 id:1 of https://codereview.chromium.org/1210073003/) Reason for revert: Reverting the revert since this wasn't the problem after all. Original issue's description: > Revert of content: Fix single process support for native GpuMemoryBuffers. (patchset #1 id:1 of https://codereview.chromium.org/1221473003/) > > Reason for revert: > XP_tests started failing with "missing shard" exceptions. Suspect this cl. > > https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/38438 > > Original issue's description: > > content: Fix single process support for native GpuMemoryBuffers. > > > > Also add the startup message filter for CreateGpuMemoryBuffer > > messages in single process mode. > > > > BUG=497559, 504121 > > > > Committed: https://crrev.com/29ec87df6cef29b9f28dd21d385f16ce99df9ce3 > > Cr-Commit-Position: refs/heads/master@{#336495} > > TBR=piman@chromium.org,reveman@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=497559, 504121 > > Committed: https://crrev.com/1cf221f6cebc8850220100c24d00a18ad54bfe8d > Cr-Commit-Position: refs/heads/master@{#336531} TBR=piman@chromium.org,reveman@chromium.org,kcarattini@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497559, 504121 Committed: https://crrev.com/8c64842afac7b46fd5842de1e3b6b4af24d98bc2 Cr-Commit-Position: refs/heads/master@{#336593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M content/gpu/gpu_child_thread.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/gpu/in_process_gpu_thread.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/gpu/in_process_gpu_thread.cc View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
Created Revert of Revert of content: Fix single process support for native GpuMemoryBuffers.
5 years, 5 months ago (2015-06-29 18:13:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218783003/1
5 years, 5 months ago (2015-06-29 18:15:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 18:17:27 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 18:19:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c64842afac7b46fd5842de1e3b6b4af24d98bc2
Cr-Commit-Position: refs/heads/master@{#336593}

Powered by Google App Engine
This is Rietveld 408576698