Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1218743008: Revert of Convert ipc_mojo_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by Derek Bruening
Modified:
5 years, 5 months ago
Reviewers:
Nico, viettrungluu, M-A Ruel
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert ipc_mojo_unittests to run exclusively on Swarming (patchset #1 id:1 of https://codereview.chromium.org/1222243003/) Reason for revert: Results in data races on ThreadSanitizer MFYI bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/6970 Original issue's description: > Convert ipc_mojo_unittests to run exclusively on Swarming > > 0 configs already ran on Swarming > 8 used to run locally and were converted: > - chromium.linux.json: Android GN > - chromium.linux.json: Linux Tests > - chromium.linux.json: Linux Tests (dbg)(1) > - chromium.linux.json: Linux Tests (dbg)(1)(32) > - chromium.memory.fyi.json: Linux ChromeOS MSan Tests > - chromium.memory.fyi.json: Linux MSan Tests > - chromium.memory.fyi.json: Linux TSan Tests > - chromium.win.json: XP Tests (1) > > Ran: > ./manage.py --convert ipc_mojo_unittests > > BUG=98637 > > Committed: https://crrev.com/15593557f4f387d91dc7726511a20cb999c81561 > Cr-Commit-Position: refs/heads/master@{#337431} TBR=viettrungluu@chromium.org,maruel@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/88f5fa1663ae01c1474f6efa733f222ae494e867 Cr-Commit-Position: refs/heads/master@{#337473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -126 lines) Patch
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/mojo/ipc_mojo.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
D ipc/mojo/ipc_mojo_unittests.isolate View 1 chunk +0 lines, -20 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 6 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 7 chunks +0 lines, -21 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 6 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Bruening
Created Revert of Convert ipc_mojo_unittests to run exclusively on Swarming
5 years, 5 months ago (2015-07-06 21:05:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218743008/1
5 years, 5 months ago (2015-07-06 21:05:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 21:08:25 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 21:09:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88f5fa1663ae01c1474f6efa733f222ae494e867
Cr-Commit-Position: refs/heads/master@{#337473}

Powered by Google App Engine
This is Rietveld 408576698