Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1218743005: Revert of Convert ppapi_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by Derek Bruening
Modified:
5 years, 5 months ago
Reviewers:
Nico, raymes, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert ppapi_unittests to run exclusively on Swarming (patchset #1 id:1 of https://codereview.chromium.org/1224453003/) Reason for revert: Results in multiple data races reported on ppapi_unittests by ThreadSanitizer Original issue's description: > Convert ppapi_unittests to run exclusively on Swarming > > 0 configs already ran on Swarming > 46 used to run locally and were converted: > - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) > - chromium.chromiumos.json: Linux ChromiumOS Tests (1) > - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) > - chromium.fyi.json: ClangToTLinux tester > - chromium.fyi.json: ClangToTLinuxASan tester > - chromium.fyi.json: ClangToTMac tester > - chromium.fyi.json: ClangToTMacASan tester > - chromium.fyi.json: ClangToTWin tester > - chromium.fyi.json: ClangToTWin(dbg) tester > - chromium.fyi.json: ClangToTWin(dll) tester > - chromium.fyi.json: ClangToTWin64 tester > - chromium.fyi.json: ClangToTWin64(dbg) tester > - chromium.fyi.json: ClangToTWin64(dll) tester > - chromium.fyi.json: CrWinAsan tester > - chromium.fyi.json: CrWinAsan(dll) tester > - chromium.fyi.json: CrWinClang tester > - chromium.fyi.json: CrWinClang(dbg) tester > - chromium.fyi.json: CrWinClang(shared) tester > - chromium.fyi.json: CrWinClang64 tester > - chromium.fyi.json: CrWinClang64(dbg) tester > - chromium.fyi.json: CrWinClang64(dll) tester > - chromium.fyi.json: CrWinClangLLD tester > - chromium.fyi.json: Linux Trusty > - chromium.fyi.json: Linux Trusty (dbg) > - chromium.linux.json: Cast Linux > - chromium.linux.json: Linux Tests > - chromium.linux.json: Linux Tests (dbg)(1) > - chromium.linux.json: Linux Tests (dbg)(1)(32) > - chromium.mac.json: Mac10.10 Tests > - chromium.mac.json: Mac10.6 Tests > - chromium.mac.json: Mac10.8 Tests > - chromium.mac.json: Mac10.9 Tests > - chromium.mac.json: Mac10.9 Tests (dbg) > - chromium.memory.fyi.json: Linux ChromeOS MSan Tests > - chromium.memory.fyi.json: Linux MSan Tests > - chromium.memory.fyi.json: Linux TSan Tests > - chromium.memory.json: Linux ASan LSan Tests (1) > - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) > - chromium.memory.json: Mac ASan 64 Tests (1) > - chromium.webkit.json: Linux ChromiumOS Tests (1) > - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) > - chromium.win.json: Vista Tests (1) > - chromium.win.json: Win 7 Tests x64 (1) > - chromium.win.json: Win7 Tests (1) > - chromium.win.json: Win7 Tests (dbg)(1) > - chromium.win.json: XP Tests (1) > > Ran: > ./manage.py --convert ppapi_unittests > > BUG=98637 > > Committed: https://crrev.com/0e660cb50e66dc9d5e794d63b4bd72079acefc2e > Cr-Commit-Position: refs/heads/master@{#337272} TBR=raymes@chromium.org,maruel@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Committed: https://crrev.com/823b8242e43a402224364a3068a011056d4f371a Cr-Commit-Position: refs/heads/master@{#337347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -174 lines) Patch
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D ppapi/ppapi_unittests.isolate View 1 chunk +0 lines, -20 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 21 chunks +0 lines, -63 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +0 lines, -15 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Derek Bruening
Created Revert of Convert ppapi_unittests to run exclusively on Swarming
5 years, 5 months ago (2015-07-05 03:43:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218743005/1
5 years, 5 months ago (2015-07-05 03:43:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-05 03:44:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/823b8242e43a402224364a3068a011056d4f371a Cr-Commit-Position: refs/heads/master@{#337347}
5 years, 5 months ago (2015-07-05 03:45:03 UTC) #4
Nico
This has 0 impact on the tsan bot. It doesn't change code, and it doesn't ...
5 years, 5 months ago (2015-07-05 05:44:39 UTC) #5
Nico
Oh, actually it does impact the bot config. I'll take a look I guess. (maruel: ...
5 years, 5 months ago (2015-07-05 05:45:46 UTC) #6
M-A Ruel
Derek, thanks for the revert but can you include the builder name next time? I ...
5 years, 5 months ago (2015-07-06 15:30:42 UTC) #7
chromium-reviews
5 years, 5 months ago (2015-07-06 16:53:27 UTC) #8
Message was sent while issue was closed.
On Mon, Jul 6, 2015 at 11:30 AM, <maruel@chromium.org> wrote:

> Derek, thanks for the revert but can you include the builder name next
> time? I
> found it back as:
>
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests...
>

Sure.  I had already sent details to Nico in an earlier email.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698