Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1218663012: Remove SkImage::NewFromBitmap encoded data helper (Closed)

Created:
5 years, 5 months ago by f(malita)
Modified:
5 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkImage::NewFromBitmap encoded data helper Attempting to instantiate image decoders at this stage introduces embedder dependencies. Instead, we can just let callers set up any needed generators on the bitmap. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/21217abe0d5d1defd414a2b78be3893efa7626c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/image/SkImage.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218663012/1
5 years, 5 months ago (2015-07-08 18:19:45 UTC) #2
f(malita)
5 years, 5 months ago (2015-07-08 18:24:30 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-08 18:29:54 UTC) #5
reed1
lgtm
5 years, 5 months ago (2015-07-08 18:32:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218663012/1
5 years, 5 months ago (2015-07-08 18:33:52 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 18:34:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/21217abe0d5d1defd414a2b78be3893efa7626c1

Powered by Google App Engine
This is Rietveld 408576698