Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1218663009: Delete from non-array end by trimming the backing store (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Delete from non-array end by trimming the backing store Committed: https://crrev.com/44dcc0a2c02e65de68e67d3982639ffd95bcd7fb Cr-Commit-Position: refs/heads/master@{#29521}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase and fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M src/elements.cc View 1 2 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-07 11:25:39 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-07 13:48:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218663009/1
5 years, 5 months ago (2015-07-07 14:26:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/7376)
5 years, 5 months ago (2015-07-07 15:07:14 UTC) #7
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-07 15:38:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218663009/40001
5 years, 5 months ago (2015-07-07 15:44:29 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-07 16:02:35 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 16:02:49 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44dcc0a2c02e65de68e67d3982639ffd95bcd7fb
Cr-Commit-Position: refs/heads/master@{#29521}

Powered by Google App Engine
This is Rietveld 408576698