Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1218633003: Make it possible to run a test in sky_shell (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make it possible to run a test in sky_shell This CL makes it possible to run sky/tests/raw/bogus_import.dart in sky_shell on Linux. We'd eventually like to scale this up to running all the tests. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c7a7d2c08ea8ae1f5107e320b11493020a0d6c27

Patch Set 1 #

Patch Set 2 : Moar EOF #

Total comments: 5

Patch Set 3 : address reviewer comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -34 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/services/testing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M sky/shell/linux/main.cc View 3 chunks +13 lines, -24 lines 0 comments Download
M sky/shell/linux/platform_service_provider_linux.cc View 1 chunk +22 lines, -3 lines 0 comments Download
A sky/shell/testing/test_runner.h View 1 chunk +62 lines, -0 lines 0 comments Download
A sky/shell/testing/test_runner.cc View 1 2 1 chunk +128 lines, -0 lines 0 comments Download
M sky/tests/resources/unit.dart View 2 chunks +16 lines, -2 lines 0 comments Download
M sky/tools/tester/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-06-27 09:30:43 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1218633003/diff/20001/sky/shell/testing/test_runner.cc File sky/shell/testing/test_runner.cc (right): https://codereview.chromium.org/1218633003/diff/20001/sky/shell/testing/test_runner.cc#newcode26 sky/shell/testing/test_runner.cc:26: void WaitForURL(UrlData& data) { This code is banana ...
5 years, 5 months ago (2015-06-29 16:53:59 UTC) #2
abarth-chromium
Committed patchset #3 (id:40001) manually as c7a7d2c08ea8ae1f5107e320b11493020a0d6c27 (presubmit successful).
5 years, 5 months ago (2015-06-29 17:39:48 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-06-30 21:38:31 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1218633003/diff/20001/sky/shell/testing/test_...
File sky/shell/testing/test_runner.cc (right):

https://codereview.chromium.org/1218633003/diff/20001/sky/shell/testing/test_...
sky/shell/testing/test_runner.cc:59:
viewport_observer_->OnViewportMetricsChanged(320, 640, 1.0);
On 2015/06/29 at 16:53:59, eseidel wrote:
> How did we standardize on sub-VGA?

We can change this to be whatever you like.  This value matches the value in the
existing test runner.

Powered by Google App Engine
This is Rietveld 408576698