Chromium Code Reviews| Index: chrome/installer/util/google_chrome_distribution.cc |
| =================================================================== |
| --- chrome/installer/util/google_chrome_distribution.cc (revision 180442) |
| +++ chrome/installer/util/google_chrome_distribution.cc (working copy) |
| @@ -290,9 +290,9 @@ |
| product_guid_(kChromeGuid) { |
| } |
| -// The functions below are not used by the 64-bit Windows binary - |
| +// The functions below are not used by the NaCl 64-bit Windows binary - |
| // see the comment in google_chrome_distribution_dummy.cc |
| -#ifndef _WIN64 |
| +#if !defined(NACL_WIN64) |
|
grt (UTC plus 2)
2013/02/04 19:03:47
under what conditions is this file compiled with N
jschuh
2013/02/04 19:16:41
NACL_WIN64 is enabled when building a 64-bit NaCl
grt (UTC plus 2)
2013/02/04 19:34:39
I don't see this file ever being compiled with tha
robertshield
2013/02/04 19:44:33
What Greg said, at first glance it looks like ever
|
| bool GoogleChromeDistribution::BuildUninstallMetricsString( |
| const DictionaryValue* uninstall_metrics_dict, string16* metrics) { |
| DCHECK(NULL != metrics); |
| @@ -357,7 +357,7 @@ |
| return true; |
| } |
| -#endif |
| +#endif // if !defined(NACL_WIN64). |
| void GoogleChromeDistribution::DoPostUninstallOperations( |
| const Version& version, |
| @@ -574,7 +574,7 @@ |
| // The functions below are not used by the 64-bit Windows binary - |
| // see the comment in google_chrome_distribution_dummy.cc |
| -#ifndef _WIN64 |
| +#if !defined(NACL_WIN64) |
| // A helper function that writes to HKLM if the handle was passed through the |
| // command line, but HKCU otherwise. |experiment_group| is the value to write |
| // and |last_write| is used when writing to HKLM to determine whether to close |
| @@ -872,7 +872,7 @@ |
| GetType())); |
| base::LaunchProcess(cmd, base::LaunchOptions(), NULL); |
| } |
| -#endif // ifndef _WIN64 |
| +#endif // if !defined(NACL_WIN64). |
| bool GoogleChromeDistribution::ShouldSetExperimentLabels() { |
| return true; |