Issue 12186005: fix x32 handling of Atomic64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12186005: fix x32 handling of Atomic64 (Closed)

Created:
7 years, 10 months ago by vapier

Modified:
7 years, 10 months ago

Reviewers:
brettw, jhawkins

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

fix x32 handling of Atomic64 The x32 logic for the size of Atomic64 handles NaCL, but misses the Linux case. Check the standard __ILP32__ to handle that too. BUG=chromium-os:36866 TEST=compiled the code for x86_64 (64bit) & x86_64 (x32) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181114

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/atomicops.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/12186005/diff/1/base/atomicops.h File base/atomicops.h (right): https://codereview.chromium.org/12186005/diff/1/base/atomicops.h#newcode50 base/atomicops.h:50: #if defined(OS_NACL) || defined(__ILP32__) Can you put the ...

7 years, 10 months ago (2013-02-06 19:10:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vapier@chromium.org/12186005/5001

7 years, 10 months ago (2013-02-06 19:41:36 UTC) #3

Message was sent while issue was closed.

Change committed as 181114

Expand Messages | Collapse Messages