Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Unified Diff: chrome/browser/metrics/perf_provider_chromeos.h

Issue 1218583002: metrics: Add dbus interface for GetRandomPerfOutput (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check that the dbus method returns some data Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/perf_provider_chromeos.h
diff --git a/chrome/browser/metrics/perf_provider_chromeos.h b/chrome/browser/metrics/perf_provider_chromeos.h
index 8353be5f59b32f9574b8566fa119a2fc6f065e26..1ccddd2f79044e5aa31f7ad25f0ba839fea6779a 100644
--- a/chrome/browser/metrics/perf_provider_chromeos.h
+++ b/chrome/browser/metrics/perf_provider_chromeos.h
@@ -93,14 +93,18 @@ class PerfProvider : public base::NonThreadSafe,
const base::TimeDelta& time_after_restore,
int num_tabs_restored);
- // Parses a perf data protobuf from the |data| passed in only if the
- // |incognito_observer| indicates that no incognito window had been opened
- // during the profile collection period.
+ // Parses a PerfDataProto from serialized data |perf_data|, if it exists.
+ // Parses a PerfStatProto from serialized data |perf_stat|, if it exists.
+ // |incognito_observer| indicates whether an incognito window had been opened
+ // during the profile collection period. If there was an incognito window,
+ // discard the incoming data.
// |trigger_event| is the cause of the perf data collection.
- void ParseProtoIfValid(
+ void ParseOutputProtoIfValid(
scoped_ptr<WindowedIncognitoObserver> incognito_observer,
scoped_ptr<SampledProfile> sampled_profile,
- const std::vector<uint8>& data);
+ int result,
Ilya Sherman 2015/06/27 05:44:24 Please document the |result|.
Simon Que 2015/06/30 05:28:09 Done.
+ const std::vector<uint8>& perf_data,
+ const std::vector<uint8>& perf_stat);
// Vector of SampledProfile protobufs containing perf profiles.
std::vector<SampledProfile> cached_perf_data_;
« no previous file with comments | « no previous file | chrome/browser/metrics/perf_provider_chromeos.cc » ('j') | chrome/browser/metrics/perf_provider_chromeos.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698