Change d8 Worker API so it takes a string instead of a function.

Change d8 Worker API so it takes a string instead of a function.

This is more consistent with the DOM API, and is clearer w.r.t. which values
are available in the lexical environment of the Worker.

BUG=chromium:497295
R=jarin@chromium.org
LOG=n

Committed: https://crrev.com/ffa6b5fe6c7a69915141e23dcbfb727e15611d2c
Cr-Commit-Position: refs/heads/master@{#29426}

[binji, 2015-06-30 20:44:58]

PTAL

Feel free to land if y'all decide that you prefer it this way. :)

[Jarin, 2015-07-01 07:35:44]

lgtm once you fix the comment in d8-worker-sharedarraybuffer.js.

https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker-...
File test/mjsunit/d8-worker-sharedarraybuffer.js (right):

https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker-...
test/mjsunit/d8-worker-sharedarraybuffer.js:42: // Atomically update ta[0]\n"
Nit: remove the extra stuff at the end of the line.

https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker.js
File test/mjsunit/d8-worker.js (right):

https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker....
test/mjsunit/d8-worker.js:33: "postMessage('Starting worker');\n" +
You might consider using the new shiny template strings for multi-line strings.
Example:

`a
 b`

See
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/template_strings.

[Jarin, 2015-07-01 07:35:47]

lgtm once you fix the comment in d8-worker-sharedarraybuffer.js.

[binji, 2015-07-01 16:13:53]

https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker-...
File test/mjsunit/d8-worker-sharedarraybuffer.js (right):

https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker-...
test/mjsunit/d8-worker-sharedarraybuffer.js:42: // Atomically update ta[0]\n"
On 2015/07/01 at 07:35:43, jarin wrote:
> Nit: remove the extra stuff at the end of the line.

Done.

https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker.js
File test/mjsunit/d8-worker.js (right):

https://codereview.chromium.org/1218553004/diff/20001/test/mjsunit/d8-worker....
test/mjsunit/d8-worker.js:33: "postMessage('Starting worker');\n" +
On 2015/07/01 at 07:35:44, jarin wrote:
> You might consider using the new shiny template strings for multi-line
strings. Example:
> 
> `a
>  b`
> 
> See
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/template_strings.

Ah, I didn't know about this. Thanks!

[binji, 2015-07-01 16:39:49]

The CQ bit was checked by binji@chromium.org

[binji, 2015-07-01 16:39:49]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1218553004/#ps40001
(title: "use template strings")

[commit-bot: I haz the power, 2015-07-01 16:39:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218553004/40001

[commit-bot: I haz the power, 2015-07-01 16:41:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-01 16:42:06]

Patchset 3 (id:??) landed as
https://crrev.com/ffa6b5fe6c7a69915141e23dcbfb727e15611d2c
Cr-Commit-Position: refs/heads/master@{#29426}