Issue 1218523002: Revert of Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218523002: Revert of Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS (Closed)

Created:
5 years, 6 months ago by reed1

Modified:
5 years, 6 months ago

Reviewers:
scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS (patchset #1 id:1 of https://codereview.chromium.org/1203983003/) Reason for revert: fixes have landed in android Original issue's description: > Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS (patchset #1 id:1 of https://codereview.chromium.org/1200323005/) > > Reason for revert: > Breaking the Android build. > > Original issue's description: > > remove SK_SUPPORT_LEGACY_PATHOP_ENUMS > > > > BUG=skia: > > TBR= > > > > Committed: https://skia.googlesource.com/skia/+/8bcc7a00febd737f7e82513bd5e4a697526626de > > TBR=reed@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ba9a4aa8550c982c480d03cb6ba2cabaf6209b41 TBR=scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/cdb42bb55c3bdbbd6682dcd50b5c77322bb6e565

Patch Set 1 #

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -19 lines)			Patch
	M	include/pathops/SkPathOps.h	View		2 chunks	+0 lines, -13 lines	0 comments	Download
	M	src/pdf/SkPDFDevice.cpp	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed1

Created Revert of Revert of remove SK_SUPPORT_LEGACY_PATHOP_ENUMS

5 years, 6 months ago (2015-06-26 17:22:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218523002/1

5 years, 6 months ago (2015-06-26 17:23:03 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cdb42bb55c3bdbbd6682dcd50b5c77322bb6e565

5 years, 6 months ago (2015-06-26 17:23:11 UTC) #3

scroggo

5 years, 6 months ago (2015-06-26 17:29:52 UTC) #4

Message was sent while issue was closed.

On 2015/06/26 17:23:11, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/cdb42bb55c3bdbbd6682dcd50b5c77322bb6e565

lgtm

Expand Messages | Collapse Messages