Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: src/x64/debug-x64.cc

Issue 1218493005: Debugger: use debug break slots instead of ICs (except for calls). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parser.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 void DebugCodegen::GenerateCallICStubDebugBreak(MacroAssembler* masm) { 152 void DebugCodegen::GenerateCallICStubDebugBreak(MacroAssembler* masm) {
153 // Register state for CallICStub 153 // Register state for CallICStub
154 // ----------- S t a t e ------------- 154 // ----------- S t a t e -------------
155 // -- rdx : type feedback slot (smi) 155 // -- rdx : type feedback slot (smi)
156 // -- rdi : function 156 // -- rdi : function
157 // ----------------------------------- 157 // -----------------------------------
158 Generate_DebugBreakCallHelper(masm, rdx.bit() | rdi.bit(), 0, false); 158 Generate_DebugBreakCallHelper(masm, rdx.bit() | rdi.bit(), 0, false);
159 } 159 }
160 160
161 161
162 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) {
163 // Register state for IC load call (from ic-x64.cc).
164 Register receiver = LoadDescriptor::ReceiverRegister();
165 Register name = LoadDescriptor::NameRegister();
166 Register slot = LoadDescriptor::SlotRegister();
167 RegList regs = receiver.bit() | name.bit() | slot.bit();
168 Generate_DebugBreakCallHelper(masm, regs, 0, false);
169 }
170
171
172 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
173 // Register state for IC store call (from ic-x64.cc).
174 Register receiver = StoreDescriptor::ReceiverRegister();
175 Register name = StoreDescriptor::NameRegister();
176 Register value = StoreDescriptor::ValueRegister();
177 RegList regs = receiver.bit() | name.bit() | value.bit();
178 if (FLAG_vector_stores) {
179 regs |= VectorStoreICDescriptor::SlotRegister().bit();
180 }
181 Generate_DebugBreakCallHelper(masm, regs, 0, false);
182 }
183
184
185 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
186 // Register state for keyed IC load call (from ic-x64.cc).
187 GenerateLoadICDebugBreak(masm);
188 }
189
190
191 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
192 // Register state for keyed IC store call (from ic-x64.cc).
193 GenerateStoreICDebugBreak(masm);
194 }
195
196
197 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
198 // Register state for CompareNil IC
199 // ----------- S t a t e -------------
200 // -- rax : value
201 // -----------------------------------
202 Generate_DebugBreakCallHelper(masm, rax.bit(), 0, false);
203 }
204
205
206 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 162 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
207 // Register state just before return from JS function (from codegen-x64.cc). 163 // Register state just before return from JS function (from codegen-x64.cc).
208 // ----------- S t a t e ------------- 164 // ----------- S t a t e -------------
209 // -- rax: return value 165 // -- rax: return value
210 // ----------------------------------- 166 // -----------------------------------
211 Generate_DebugBreakCallHelper(masm, rax.bit(), 0, true); 167 Generate_DebugBreakCallHelper(masm, rax.bit(), 0, true);
212 } 168 }
213 169
214 170
215 void DebugCodegen::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) { 171 void DebugCodegen::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) {
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 } 254 }
299 255
300 const bool LiveEdit::kFrameDropperSupported = true; 256 const bool LiveEdit::kFrameDropperSupported = true;
301 257
302 #undef __ 258 #undef __
303 259
304 } // namespace internal 260 } // namespace internal
305 } // namespace v8 261 } // namespace v8
306 262
307 #endif // V8_TARGET_ARCH_X64 263 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/parser.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698