Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: src/mips64/debug-mips64.cc

Issue 1218493005: Debugger: use debug break slots instead of ICs (except for calls). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_MIPS64 9 #if V8_TARGET_ARCH_MIPS64
10 10
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 void DebugCodegen::GenerateCallICStubDebugBreak(MacroAssembler* masm) { 146 void DebugCodegen::GenerateCallICStubDebugBreak(MacroAssembler* masm) {
147 // Register state for CallICStub 147 // Register state for CallICStub
148 // ----------- S t a t e ------------- 148 // ----------- S t a t e -------------
149 // -- a1 : function 149 // -- a1 : function
150 // -- a3 : slot in feedback array (smi) 150 // -- a3 : slot in feedback array (smi)
151 // ----------------------------------- 151 // -----------------------------------
152 Generate_DebugBreakCallHelper(masm, a1.bit() | a3.bit(), 0); 152 Generate_DebugBreakCallHelper(masm, a1.bit() | a3.bit(), 0);
153 } 153 }
154 154
155 155
156 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) {
157 Register receiver = LoadDescriptor::ReceiverRegister();
158 Register name = LoadDescriptor::NameRegister();
159 Register slot = LoadDescriptor::SlotRegister();
160 RegList regs = receiver.bit() | name.bit() | slot.bit();
161 Generate_DebugBreakCallHelper(masm, regs, 0);
162 }
163
164
165 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
166 Register receiver = StoreDescriptor::ReceiverRegister();
167 Register name = StoreDescriptor::NameRegister();
168 Register value = StoreDescriptor::ValueRegister();
169 RegList regs = receiver.bit() | name.bit() | value.bit();
170 if (FLAG_vector_stores) {
171 regs |= VectorStoreICDescriptor::SlotRegister().bit();
172 }
173 Generate_DebugBreakCallHelper(masm, regs, 0);
174 }
175
176
177 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
178 // Calling convention for keyed IC load (from ic-mips64.cc).
179 GenerateLoadICDebugBreak(masm);
180 }
181
182
183 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
184 // Calling convention for IC keyed store call (from ic-mips64.cc).
185 GenerateStoreICDebugBreak(masm);
186 }
187
188
189 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
190 // Register state for CompareNil IC
191 // ----------- S t a t e -------------
192 // -- a0 : value
193 // -----------------------------------
194 Generate_DebugBreakCallHelper(masm, a0.bit(), 0);
195 }
196
197
198 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 156 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
199 // In places other than IC call sites it is expected that v0 is TOS which 157 // In places other than IC call sites it is expected that v0 is TOS which
200 // is an object - this is not generally the case so this should be used with 158 // is an object - this is not generally the case so this should be used with
201 // care. 159 // care.
202 Generate_DebugBreakCallHelper(masm, v0.bit(), 0); 160 Generate_DebugBreakCallHelper(masm, v0.bit(), 0);
203 } 161 }
204 162
205 163
206 void DebugCodegen::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) { 164 void DebugCodegen::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) {
207 // Register state for CallFunctionStub (from code-stubs-mips.cc). 165 // Register state for CallFunctionStub (from code-stubs-mips.cc).
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 247
290 248
291 const bool LiveEdit::kFrameDropperSupported = true; 249 const bool LiveEdit::kFrameDropperSupported = true;
292 250
293 #undef __ 251 #undef __
294 252
295 } // namespace internal 253 } // namespace internal
296 } // namespace v8 254 } // namespace v8
297 255
298 #endif // V8_TARGET_ARCH_MIPS64 256 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698