Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm64/debug-arm64.cc

Issue 1218493005: Debugger: use debug break slots instead of ICs (except for calls). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 void DebugCodegen::GenerateCallICStubDebugBreak(MacroAssembler* masm) { 196 void DebugCodegen::GenerateCallICStubDebugBreak(MacroAssembler* masm) {
197 // Register state for CallICStub 197 // Register state for CallICStub
198 // ----------- S t a t e ------------- 198 // ----------- S t a t e -------------
199 // -- x1 : function 199 // -- x1 : function
200 // -- x3 : slot in feedback array 200 // -- x3 : slot in feedback array
201 // ----------------------------------- 201 // -----------------------------------
202 Generate_DebugBreakCallHelper(masm, x1.Bit() | x3.Bit(), 0, x10); 202 Generate_DebugBreakCallHelper(masm, x1.Bit() | x3.Bit(), 0, x10);
203 } 203 }
204 204
205 205
206 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) {
207 // Calling convention for IC load (from ic-arm.cc).
208 Register receiver = LoadDescriptor::ReceiverRegister();
209 Register name = LoadDescriptor::NameRegister();
210 Register slot = LoadDescriptor::SlotRegister();
211 RegList regs = receiver.Bit() | name.Bit() | slot.Bit();
212 Generate_DebugBreakCallHelper(masm, regs, 0, x10);
213 }
214
215
216 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
217 // Calling convention for IC store (from ic-arm64.cc).
218 Register receiver = StoreDescriptor::ReceiverRegister();
219 Register name = StoreDescriptor::NameRegister();
220 Register value = StoreDescriptor::ValueRegister();
221 RegList regs = receiver.Bit() | name.Bit() | value.Bit();
222 if (FLAG_vector_stores) {
223 regs |= VectorStoreICDescriptor::SlotRegister().Bit();
224 }
225 Generate_DebugBreakCallHelper(masm, regs, 0, x10);
226 }
227
228
229 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
230 // Calling convention for keyed IC load (from ic-arm.cc).
231 GenerateLoadICDebugBreak(masm);
232 }
233
234
235 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
236 // Calling convention for IC keyed store call (from ic-arm64.cc).
237 GenerateStoreICDebugBreak(masm);
238 }
239
240
241 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
242 // Register state for CompareNil IC
243 // ----------- S t a t e -------------
244 // -- r0 : value
245 // -----------------------------------
246 Generate_DebugBreakCallHelper(masm, x0.Bit(), 0, x10);
247 }
248
249
250 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 206 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
251 // In places other than IC call sites it is expected that r0 is TOS which 207 // In places other than IC call sites it is expected that r0 is TOS which
252 // is an object - this is not generally the case so this should be used with 208 // is an object - this is not generally the case so this should be used with
253 // care. 209 // care.
254 Generate_DebugBreakCallHelper(masm, x0.Bit(), 0, x10); 210 Generate_DebugBreakCallHelper(masm, x0.Bit(), 0, x10);
255 } 211 }
256 212
257 213
258 void DebugCodegen::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) { 214 void DebugCodegen::GenerateCallFunctionStubDebugBreak(MacroAssembler* masm) {
259 // Register state for CallFunctionStub (from code-stubs-arm64.cc). 215 // Register state for CallFunctionStub (from code-stubs-arm64.cc).
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 __ Br(scratch); 296 __ Br(scratch);
341 } 297 }
342 298
343 299
344 const bool LiveEdit::kFrameDropperSupported = true; 300 const bool LiveEdit::kFrameDropperSupported = true;
345 301
346 } // namespace internal 302 } // namespace internal
347 } // namespace v8 303 } // namespace v8
348 304
349 #endif // V8_TARGET_ARCH_ARM64 305 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698